Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading to Meteor 1.8 and Akryum:vue-router2@0.2.2 sourcemap error #336

Open
jamesgibson14 opened this issue Oct 27, 2018 · 12 comments

Comments

@jamesgibson14
Copy link

Errors prevented startup:

While processing files with akryum:vue-router2 (for target web.browser):

/Users/jamesgibson/.meteor/packages/akryum_vue-router2/.0.2.2.3d8cvj.f7f9++os+web.browser+web.browser.legacy+web.cordova/plugin.vue-router.os/npm/node_modules/meteor/babel-compiler/node_modules/@babel/core/lib/config/validation/options.js:123:11:
.sourceMap is an alias for .sourceMaps, cannot use both
at assertNoDuplicateSourcemap

@GeneralAldo
Copy link

Any way to get around this?

@mwarren2
Copy link

mwarren2 commented Dec 18, 2018

Take look at this babel fix:
babel/babel-loader#670

This makes me think that the problem is on line 41 of the vue-router2 plug-in: https://github.com/meteor-vue/vue-meteor/blob/master/packages/vue-router2/plugin/plugin.js

babelOptions.sourceMap = true

should presumably be changed to

babelOptions.sourceMaps = true


However after making above change it then fails with another message:

Using removed Babel 6 option: .sourceMapTarget - The sourceMapTarget option has been removed because it makes more sense for the tooling that calls Babel to assign map.file themselves.

So I also removed the line:
babelOptions.sourceMapTarget = babelOptions.filename + '.map'

It now compiles correctly

@mwarren2
Copy link

mwarren2 commented Dec 18, 2018

Would be nice if this was fixed soonest.

Otherwise we are still stuck with Meteor 1.7

Thanks !

@rekDen
Copy link

rekDen commented Jan 7, 2019

Hey mwarren2,

my team mate @ahmelkady and me figured it out how to temporarily "solve" this issue.
For us it worked to downgrade akryum_vue-router2 from 0.2.2 to 0.2.0 by changing manually the .meteor/versions file.

Best regards

@mwarren2
Copy link

mwarren2 commented Jan 7, 2019

@rekDen
Good idea. I'll downgrade until the problem is fixed

@mwarren2
Copy link

@Akryum Any chance of this being fixed? It looks like a simple fix yet It is forcing us to stay with Meteor 1.7.

Please see my comments further up this page. I have outlined what I think needs to be done.
I have forked vue-router2 and tested the changes and it all works, however I appreciate that obviously I don't have your expertise...

Many thanks.

@rpesciotta
Copy link

Just to +1 this, I'm a new user to the vue/meteor combination (although working with meteor for ~3 years), and starting a project with meteor 1.8 and the akryum set of packages to enable this integration, and right at the beginning, run into this issue.
I'd be glad to see this fixed soon too.
Thanks in advance!

@mwarren2
Copy link

I've replaced akryum:vue-router2 with vue-router.
Though I'm still using other akryum vue code.

@sebbean
Copy link

sebbean commented Nov 6, 2019

hey @mwarren2 what do you mean by replaced?

in which file?

@wildhart
Copy link
Contributor

wildhart commented Nov 6, 2019

@sebbean:

meteor remove akryum:vue-router2
meteor npm install --save vue-router

I've never used the akryum version, standard vue-router works perfectly well with Meteor 1.8

@mwarren2
Copy link

mwarren2 commented Nov 6, 2019

hey @mwarren2 what do you mean by replaced?

in which file?

Please see @wildhart answer

@jamesgibson14
Copy link
Author

jamesgibson14 commented Jan 9, 2020

I just updated to Meteor 1.8.3 and used @wildhart 's suggestion to use the npm package directly. I had to change of view things to migrate, like importing the path/route components directly, and changing a a few other lines of code, but it seems to be working very well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants