Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing delimited * incorrect for consecutive ocurrences #1594

Closed
damianon opened this issue Jan 10, 2020 · 1 comment · Fixed by #1644
Closed

Closing delimited * incorrect for consecutive ocurrences #1594

damianon opened this issue Jan 10, 2020 · 1 comment · Fixed by #1644
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@damianon
Copy link

damianon commented Jan 10, 2020

Describe the bug
When ** is used consecutively the closing delimiter is recognised incorrectly

To Reproduce
b**o****o**k turns into b<strong>o**</strong>o**k

Interesting enough the Marked Demo Page produces a different result: https://spec.commonmark.org/dingus/?text=b**o****o**k

Version: 0.8.0 (previously 0.7.0 with the same bug)

Expected behavior
both o's should get a separate <strong>

Tried this online editor and it works correctly: https://dillinger.io/

@UziTech UziTech added category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels Jan 10, 2020
@UziTech
Copy link
Member

UziTech commented Jan 10, 2020

*'s are supposed to only be terminated by the same number of *'s.

marked demo

looks like this has a failing test

{
"markdown": "*foo**bar***\n",
"html": "<p><em>foo<strong>bar</strong></em></p>\n",
"example": 414,
"start_line": 6902,
"end_line": 6906,
"section": "Emphasis and strong emphasis",
"shouldFail": true
},

@styfle styfle linked a pull request Apr 14, 2020 that will close this issue
4 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this issue Nov 8, 2021
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this issue Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants