New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexeddb support in Safari 10.1+ #650
Comments
Agreed, sounds good 👍🏻
|
@tofumatt do you think its a big job? I did have a quick look at it and got to that utils/isIndexedDBValid.js#L19 is where we need to change the check so that if its Safari 10.1+ its not captured by that if. |
Thinking that this changes are the same as the ones we should do to utils/isIndexedDBValid.js#L19 |
I can merge nolanlawson's changes to localforage, it shouldn't be a big
deal. My only concern is that I won't be able to do any testing since I
currently don't have any iOS device available.
--
*Thodoris Greasidis*
|
I can test them, but if it's working for PouchDB I think it should work for us. |
Have a PR here #651 |
Resolved by #651 |
I tested this jsfiddle on Safari 10.2 as commented on #604. The main page uses localstorage but when I open the result frame in a new tab it uses asyncstorage. Feel free to create codepen or jsfiddle for me test, I will be more than happy to contribute. |
Safari 10.1 has shipped with full and performant support for IndexedDB according to this PR over at pouchdb.
I think we should get this to localForage.
The text was updated successfully, but these errors were encountered: