Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexeddb support in Safari 10.1+ #650

Closed
dennismartensson opened this issue Jan 25, 2017 · 9 comments
Closed

Indexeddb support in Safari 10.1+ #650

dennismartensson opened this issue Jan 25, 2017 · 9 comments

Comments

@dennismartensson
Copy link
Contributor

Safari 10.1 has shipped with full and performant support for IndexedDB according to this PR over at pouchdb.

I think we should get this to localForage.

@tofumatt
Copy link
Member

tofumatt commented Jan 25, 2017 via email

@dennismartensson
Copy link
Contributor Author

@tofumatt do you think its a big job? I did have a quick look at it and got to that utils/isIndexedDBValid.js#L19 is where we need to change the check so that if its Safari 10.1+ its not captured by that if.

@dennismartensson
Copy link
Contributor Author

Thinking that this changes are the same as the ones we should do to utils/isIndexedDBValid.js#L19

@thgreasi
Copy link
Member

thgreasi commented Jan 25, 2017 via email

@tofumatt
Copy link
Member

I can test them, but if it's working for PouchDB I think it should work for us.

@dennismartensson
Copy link
Contributor Author

Have a PR here #651

@thgreasi
Copy link
Member

Resolved by #651

@Narcwis
Copy link

Narcwis commented Feb 9, 2017

I tested this jsfiddle on Safari 10.2 as commented on #604. The main page uses localstorage but when I open the result frame in a new tab it uses asyncstorage. Feel free to create codepen or jsfiddle for me test, I will be more than happy to contribute.

@thgreasi
Copy link
Member

thgreasi commented Feb 9, 2017

@Narcwis asyncstorage stands for IndexedDB, so your results are indicate that #651 works and this is resolved.
It seems that the safari + iframe => localstorage issue is not something we can do something for.
Thanks for your feedback confirming that this works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants