New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog preset is not correctly picked up #1896
Comments
Oh geez, sorry about that. I coulda sworn all the presets used the same patterns for their default export... We probably need to do something like this, from core. |
Thanks! PS: I honestly was startled when I looked at |
Published in v3.10.8 |
Well, I believe it was written when Q was the best way to add promises, and it really hasn't been updated since Promises became native to Node. 🤷♂️ We do accept pull requests to upgrade that code base 😅 Eventually, we'll get around to updating it, as it's still actively maintained by the @conventional-changelog team. 👍 |
@hutson Sorry, I didn't want to offend anyone. When I first digged into the codebase I was confused that it still uses |
Expected Behavior
Calling
lerna version --conventional-commits --changelog-preset <preset>
should use the given preset.In my case
conventional-changelog-emojis
EDIT: I found the issue, but I am not sure this is an issue with lerna or
conventional-changelog-core
. Since both syntax (see "Possible Solution") seem to be supported when using theconventional-changelog-cli
.Please just close this, if you want. Sorry for bothering!
Current Behavior
The preset is picked up correctly:
But the printed changelog does not use the chosen (or any preset) and prints like this:
Using conventional changelog directly works, tough. Running
conventional-changelog -p emojis -i CHANGELOG.md -s -r 0
will generate the correct changelog (in the root directory).Possible Solution
Digged intoget-changelog-config.js
but debugging is kinda hard, because ofconventional-changelog
only passing a function. But the transform function of the custom preset is never called.Seems like lerna "can not" resolve the "bloody Q.all".
Basically it is this syntax (e.g. ember preset):
https://github.com/conventional-changelog/conventional-changelog/blob/943542f3b2342bb5933d84847fb19b727c607df0/packages/conventional-changelog-ember/index.js#L10-L15
Versus this syntax (angular preset):
https://github.com/conventional-changelog/conventional-changelog/blob/943542f3b2342bb5933d84847fb19b727c607df0/packages/conventional-changelog-angular/index.js#L8-L11
The angular preset syntax works with lerna! 🙂
Steps to Reproduce (for bugs)
lerna version --conventional-commits --changelog-preset emojis
lerna.json
<!-- Please paste your `lerna.json` here -->
Context
Your Environment
lerna --version
npm --version
yarn --version
node --version
The text was updated successfully, but these errors were encountered: