--no-bail doesn't return exit code 1 when failed

[oreporan]

Based on issue found here #1374
--no-bail should return 1 if any of the commands failed, instead it returns 0 always.

Expected Behavior

if any tests/commands failed, adding --no-bail should not hide the exit code, instead it should return exit code 1 if any of the packages returned exit code 1

Current Behavior

swallows the errors and returns exit code 0

Steps to Reproduce (for bugs)

1. create package with npm command "test" : "exit 1"
2. call npm run test --no-bail

lerna.json

{
    "lerna": "2.11.0",
    "packages": [
        "packages/*",
        "web",
        "web/service_worker_container",
        "mobile",
        "packages/expert-feed/common/components/*",
        "packages/slash-commands/components/*"
    ],
    "version": "0.0.0",
    "npmClient": "yarn"
}

Context

Running CI will not allow developers see all the tests that failed, current workaround is to drop --no-bail

[evocateur]

Yeah, it's tricky. I've been noodling about this for about an hour now.

Basically, instead of using --no-bail to control the reject option passed to execa, we (probably?) need to always pass { reject: false } and do our own accounting (including setting process.exitCode, if necessary) after all the executions resolve. At least, that's how I'm exploring it right now.

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.