Failed preversion npm script alters lerna.json

[EvanLovely]

I have a npm script for preversion that runs linting. After running lerna publish that script failing stops it, but lerna.json still has a bumped version (though no package.json files do).

lerna.json

{
  "lerna": "2.11.0",
  "version": "0.4.0",
  "command": {},
  "npmClient": "yarn",
  "useWorkspaces": true
}

Executable	Version
lerna --version	2.11.0
npm --version	6.1.0
yarn --version	1.7
node --version	8.11.1

OS	Version
NAME	VERSION
macOS Sierra	10.12.3

[evocateur]

Whoops, yeah, that's definitely happening.

I've fixed it in master, which means lerna 3.x will have the fix as soon as I publish it. I don't have time to update the 2.x line, as it is a dramatically old codebase now, and I'm going to promote v3 out of beta soon.

[christophehurpeau]

With lerna 3, when preversion fails lerna still publishes:
preversion is called here:

lerna/commands/version/index.js

Line 381 in bd948cc

pkg => this.runPackageLifecycle(pkg, "preversion"),

error is catched here :

lerna/utils/run-lifecycle/run-lifecycle.js

Line 46 in bd948cc

log.error("lifecycle", `error running ${stage} in ${pkg.name}\n`, err.stack || err);

maybe it should rethrow the error after log it ?

[evocateur]

@christophehurpeau Whoops, yes, that is definitely an oversight. It should definitely re-throw, perhaps based on an opt-out config option? (lerna run has --no-bail, for example)

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.