fix(publish): Call synthetic prepublishOnly lifecycle before packing

This was lost when the unitary `npm publish` was split into `npm pack && npm publish <tgz>`. Fixes #1169
lerna · Aug 27, 2018 · dda9812 · dda9812 · artembatura · Jan 6, 2019
1 parent b4c4ee5
commit dda9812
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/commands/publish/__tests__/publish-lifecycle-scripts.test.js b/commands/publish/__tests__/publish-lifecycle-scripts.test.js
@@ -29,10 +29,14 @@ describe("lifecycle scripts", () => {
       expect(runLifecycle).toHaveBeenCalledWith(expect.objectContaining({ name: "lifecycle" }), script);
     });
 
-    // all leaf package lifecycles _EXCEPT_ postpublish are called by npm pack
+    // all leaf package lifecycles _EXCEPT_ prepublishOnly & postpublish are called by npm pack
     expect(runLifecycle).not.toHaveBeenCalledWith(
       expect.objectContaining({ name: "package-1" }),
-      expect.stringMatching(/(prepare|prepublishOnly)/)
+      expect.stringMatching("prepare")
+    );
+    expect(runLifecycle).toHaveBeenCalledWith(
+      expect.objectContaining({ name: "package-1" }),
+      expect.stringMatching("prepublishOnly")
     );
     expect(runLifecycle).toHaveBeenCalledWith(
       expect.objectContaining({ name: "package-1" }),
@@ -56,6 +60,7 @@ describe("lifecycle scripts", () => {
       // publish-specific
       ["lifecycle", "prepare"],
       ["lifecycle", "prepublishOnly"],
+      ["package-1", "prepublishOnly"],
       ["package-1", "postpublish"],
       ["lifecycle", "postpublish"],
     ]);

diff --git a/commands/publish/index.js b/commands/publish/index.js
@@ -424,7 +424,13 @@ class PublishCommand extends Command {
     chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "prepare"));
     chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "prepublishOnly"));
 
-    const actions = [];
+    const actions = [
+      pkg =>
+        // npm pack already runs prepare and prepublish
+        // prepublishOnly is _not_ run when publishing a tarball
+        // TECHNICALLY out of order, but not much we can do about that
+        this.runPackageLifecycle(pkg, "prepublishOnly"),
+    ];
 
     if (this.options.requireScripts) {
       actions.push(pkg => this.execScript(pkg, "prepublish"));

diff --git a/integration/lerna-publish-lifecycle-silent.test.js b/integration/lerna-publish-lifecycle-silent.test.js
@@ -37,6 +37,7 @@ postversion-package-1
 postversion-root
 prepare-root
 prepublishOnly-root
+prepublishOnly-package-1
 prepublish-package-1
 prepare-package-1
 postpublish-package-1

diff --git a/integration/lerna-publish-lifecycle.test.js b/integration/lerna-publish-lifecycle.test.js
@@ -70,6 +70,11 @@ prepare-root
 
 prepublishOnly-root
 
+> package-1@1.1.0 prepublishOnly __TEST_ROOTDIR__/packages/package-1
+> echo prepublishOnly-package-1
+
+prepublishOnly-package-1
+
 > package-1@1.1.0 prepublish __TEST_ROOTDIR__/packages/package-1
 > echo prepublish-package-1