feat(publish): Support prepack/postpack lifecycle in root manifest

lerna · Aug 27, 2018 · 9df88a4 · 9df88a4
1 parent dda9812
commit 9df88a4
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 1 deletion.
diff --git a/commands/publish/__tests__/__fixtures__/lifecycle/package.json b/commands/publish/__tests__/__fixtures__/lifecycle/package.json
@@ -8,6 +8,8 @@
     "prepublish": "echo prepublish-root",
     "prepare": "echo prepare-root",
     "prepublishOnly": "echo prepublishOnly-root",
+    "prepack": "echo prepack-root",
+    "postpack": "echo postpack-root",
     "postpublish": "echo postpublish-root"
   }
 }
diff --git a/commands/publish/__tests__/publish-lifecycle-scripts.test.js b/commands/publish/__tests__/publish-lifecycle-scripts.test.js
@@ -24,7 +24,7 @@ describe("lifecycle scripts", () => {
 
     await lernaPublish(cwd)();
 
-    ["prepare", "prepublishOnly", "postpublish"].forEach(script => {
+    ["prepare", "prepublishOnly", "prepack", "postpack", "postpublish"].forEach(script => {
       // "lifecycle" is the root manifest name
       expect(runLifecycle).toHaveBeenCalledWith(expect.objectContaining({ name: "lifecycle" }), script);
     });
@@ -60,7 +60,9 @@ describe("lifecycle scripts", () => {
       // publish-specific
       ["lifecycle", "prepare"],
       ["lifecycle", "prepublishOnly"],
+      ["lifecycle", "prepack"],
       ["package-1", "prepublishOnly"],
+      ["lifecycle", "postpack"],
       ["package-1", "postpublish"],
       ["lifecycle", "postpublish"],
     ]);

diff --git a/commands/publish/index.js b/commands/publish/index.js
@@ -423,6 +423,7 @@ class PublishCommand extends Command {
 
     chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "prepare"));
     chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "prepublishOnly"));
+    chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "prepack"));
 
     const actions = [
       pkg =>
@@ -453,6 +454,8 @@ class PublishCommand extends Command {
     // remove temporary license files if _any_ error occurs _anywhere_ in the promise chain
     chain = chain.catch(error => this.removeTempLicensesOnError(error));
 
+    chain = chain.then(() => this.runPackageLifecycle(this.project.manifest, "postpack"));
+
     return pFinally(chain, () => tracker.finish());
   }
 

diff --git a/integration/lerna-publish-lifecycle-silent.test.js b/integration/lerna-publish-lifecycle-silent.test.js
@@ -37,9 +37,11 @@ postversion-package-1
 postversion-root
 prepare-root
 prepublishOnly-root
+prepack-root
 prepublishOnly-package-1
 prepublish-package-1
 prepare-package-1
+postpack-root
 postpublish-package-1
 postpublish-root
 Successfully published:

diff --git a/integration/lerna-publish-lifecycle.test.js b/integration/lerna-publish-lifecycle.test.js
@@ -70,6 +70,11 @@ prepare-root
 
 prepublishOnly-root
 
+> lifecycle@0.0.0-monorepo prepack __TEST_ROOTDIR__
+> echo prepack-root
+
+prepack-root
+
 > package-1@1.1.0 prepublishOnly __TEST_ROOTDIR__/packages/package-1
 > echo prepublishOnly-package-1
 
@@ -85,6 +90,11 @@ prepublish-package-1
 
 prepare-package-1
 
+> lifecycle@0.0.0-monorepo postpack __TEST_ROOTDIR__
+> echo postpack-root
+
+postpack-root
+
 > package-1@1.1.0 postpublish __TEST_ROOTDIR__/packages/package-1
 > echo postpublish-package-1