Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc dependency breaking build #177

Closed
TwR-Slice opened this issue Sep 5, 2017 · 5 comments
Closed

JSDoc dependency breaking build #177

TwR-Slice opened this issue Sep 5, 2017 · 5 comments

Comments

@TwR-Slice
Copy link

TwR-Slice commented Sep 5, 2017

the dependency of jsdoc should change from "^3.4.0" to "~3.4.0" in version 1.1.0

JSDoc introduced babylon in 3.5.0 which is producing errors when building on older node versions.

@Mydayyy
Copy link

Mydayyy commented Sep 5, 2017

Hi,

we do encounter the same problem. I just looked a bit more into the issue:

The dependency of JSDoc is written as ^3.4.0 which also includes 3.5.0. ( Can be calculated here in case one is unfamiliar with semver ).

As jsdoc released the first 3.5.0 package on 2017-07-10T02:26:25.790Z, we run into issues during doc creation now, as npm is installing jsdoc 3.5.x.

It would be nice if it were possible to use ~3.4.0 as its dependency.

Best Regards
~Mydayyy

@krampstudio
Copy link
Owner

Yep I'll try to fix this asap

@krampstudio
Copy link
Owner

Please let me know if version 2.1.1 fix it for you all.

@Mydayyy
Copy link

Mydayyy commented Sep 5, 2017

Hi,

the problem is fixed on our side! Thank you so much for your quick reaction!

Best Regards
~Mydayyy

@TwR-Slice
Copy link
Author

I can confirm that the issue is resolved!

Thank you for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants