Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing of testHook #292

Merged
merged 2 commits into from Feb 11, 2019
Merged

Fix typing of testHook #292

merged 2 commits into from Feb 11, 2019

Conversation

Andrewmat
Copy link
Contributor

Continues pull request #290

What:

Modifies typing declaration of testHook
Also adds a section to remind contributors to check typings of API

Checklist:

  • [N/A] Documentation
  • [N/A] Tests
  • Ready to be merged
  • [N/A] Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Thanks!

@kentcdodds kentcdodds merged commit 8436c7e into testing-library:master Feb 11, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants