Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier-path & prettierPath #9

Closed
ariesshrimp opened this issue Jan 31, 2017 · 1 comment
Closed

prettier-path & prettierPath #9

ariesshrimp opened this issue Jan 31, 2017 · 1 comment

Comments

@ariesshrimp
Copy link

ariesshrimp commented Jan 31, 2017

TL:DR;

Docs say prettier-path is an option.
prettier-eslint --help says prettierPath is the option.

Both options throw an error:

$ prettier-eslint --help

Usage: prettier-eslint <globs>... [--option-1 option-1-value --option-2]

Options:
  # ...
  --prettierPath  The path to the prettier module to use
$ prettier-eslint index.js --prettierPath `which prettier`

Ignored unknown option: --prettierPath



$ prettier-eslint index.js --prettier-path `which prettier`

Ignored unknown option: --prettier-path

Question:

I take it some combination of these should be true:

  1. The README and --help should conform.
  2. Whatever the right way is should be a known option.

What's the right option? Incidentally, --write actually seems to work in both cases. Just throws an error.

To reproduce:

  1. npm i -g prettier-eslint-cli prettier // put the tools somewhere else
  2. git clone https://github.com/joefraley/test-prettier && cd test-prettier && npm i // get an mvp repo with an eslint config and a test file
  3. npm start // run cli with a defined path
  4. git diff // see that the file was changed
@kentcdodds
Copy link
Member

kentcdodds commented Jan 31, 2017

Seems like a pretty significant issue. Thank you for filing this. I'll get to it when I have the time. In the meantime, if you'd like to dig deeper to see why you're getting that error (and propose a solution to fix it, and even makeapullrequest.com?), that would be really helpful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants