Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script name in the nps is executing output #126

Closed
kentcdodds opened this issue Mar 15, 2017 · 4 comments
Closed

Add script name in the nps is executing output #126

kentcdodds opened this issue Mar 15, 2017 · 4 comments

Comments

@kentcdodds
Copy link
Collaborator

Right now if I execute:

nps f.b

I'll get something like:

nps executing: echo "foo bar"

I'd like it to say:

nps is executing foo.bar: echo "foo bar"

where foo.bar is the name (path) of the script being executed. It'd be good to get it in bold too.

Anyone wanna take this up?

@Miklet
Copy link
Collaborator

Miklet commented May 23, 2017

Since my PR for prefix-matches got merged and now it returns corresponding property chain I can get back to this issue. I have question about module resolve-script-object-to-string if it is still needed after changes. Result of prefix-matches will now always return an array of objects and also we want to get now resolved prefix with script to execute, not only script.

@kentcdodds
Copy link
Collaborator Author

Yes, the PR to support this will be much simpler now :)

@Miklet
Copy link
Collaborator

Miklet commented May 23, 2017

If it will be much simpler then I guess we can drop module resolve-script-object-to-string as I asked earlier :)?

@kentcdodds
Copy link
Collaborator Author

I expect so :) Thanks so much!

Miklet added a commit that referenced this issue May 27, 2017
Updated prefix-matches verion and added script name of executed script
kentcdodds pushed a commit that referenced this issue May 27, 2017
Updated prefix-matches verion and added script name of executed script
@Miklet Miklet closed this as completed May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants