This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
feat(kill): Propagate SIGTERM to created process #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100%@@ master #20 diff @@
===================================
Files 1 1
Lines 32 36 +4
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 32 36 +4
Misses 0 0
Partials 0 0
|
|
Looks good. Though I think this is likely to be a breaking change so I'll going to bump the major version for this one. Thanks! |
|
Thanks @kentcdodds ! I'm unsure if this is a major break change, because the public API didn't changed. |
|
Right, but I thought it's best to be safe. This has been released as 2.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using cross-env with concurrently. There is a option to kill other processes when one of them exit. But the process using cross-env never exit, because the SIGTERM is not propagated to the child process. This PR fix this issue.