Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

npm start validate errors out #116

Closed
turnerhayes opened this issue Jun 7, 2017 · 7 comments
Closed

npm start validate errors out #116

turnerhayes opened this issue Jun 7, 2017 · 7 comments

Comments

@turnerhayes
Copy link
Contributor

npm start validate errors out due to a linting error:

 src/index.test.js
 95:15  error  More than one argument was passed to expect()  jest/valid-expect

It's complaining about this line.

@kentcdodds
Copy link
Owner

Yeah, that second argument to expect should be removed. Would you like to do that?

@turnerhayes
Copy link
Contributor Author

Sure, I'll include it in my upcoming PR. I'm having a little trouble, though; I followed the CONTRIBUTING.md and created a branch for my changes, but after I got through git start commit, I have a commit but not sure how to push it; running git push, even with the --set-upstream origin option

@kentcdodds
Copy link
Owner

Ah, is this your first time contributing to open source? If so, welcome! Happy to have you! You might benefit from watching this first! Let me know how I can help after you've watched that 😀

@turnerhayes
Copy link
Contributor Author

I try pushing but it says I don't have access.

@kentcdodds
Copy link
Owner

In that video course, I show you how to create a fork which you can push to.

@turnerhayes
Copy link
Contributor Author

Ah, I can certainly use a fork; I was following the CONTRIBUTING.md directions, which specify cloning your repo and creating a branch on it (or that's what it sounded like to me) so I assumed that was your preferred contribution model and that you had somehow configured the repo to accept others' branches. I'll create a PR from a fork.

@turnerhayes
Copy link
Contributor Author

My bad, it does say "fork". I somehow skipped over that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants