Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better config/CLI args validation #603

Open
vojtajina opened this issue Jun 26, 2013 · 1 comment · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Open

better config/CLI args validation #603

vojtajina opened this issue Jun 26, 2013 · 1 comment · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@vojtajina
Copy link
Contributor

karma start test/e2e/basic/karma.conf.js --log-level

/Users/vojta/Code/karma/node_modules/log4js/lib/logger.js:56
    return this.level.isLessThanOrEqualTo(otherLevel);
                      ^
TypeError: Cannot call method 'isLessThanOrEqualTo' of undefined
    at Logger.isLevelEnabled (/Users/vojta/Code/karma/node_modules/log4js/lib/logger.js:56:23)
    at Logger.(anonymous function) [as debug] (/Users/vojta/Code/karma/node_modules/log4js/lib/logger.js:67:22)
    at requirePlugin (/Users/vojta/Code/karma/lib/plugin.js:12:9)
    at /Users/vojta/Code/karma/lib/plugin.js:38:9
    at Array.forEach (native)
    at Object.exports.resolve (/Users/vojta/Code/karma/lib/plugin.js:25:11)
    at Object.exports.start (/Users/vojta/Code/karma/lib/server.js:254:35)
    at Object.<anonymous> (/Users/vojta/Code/karma/bin/karma:20:39)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3
@vojtajina
Copy link
Contributor Author

Also stufff like:

{pattern: 'xxxx', included: 'false'}

Should 'false' be converted into a boolean false and show warning.

srawlins added a commit to srawlins/karma that referenced this issue Nov 4, 2014
Start adding better CLI args validation (karma-runner#603). Validate log-level to start.
srawlins added a commit to srawlins/karma that referenced this issue Jul 15, 2015
Start adding better CLI args validation (karma-runner#603). Validate log-level to start.
srawlins added a commit to srawlins/karma that referenced this issue Jul 16, 2015
Start adding better CLI args validation (karma-runner#603). Validate log-level to start.
@dignifiedquire dignifiedquire modified the milestone: v1.0 Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants