Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/upstream-proxy.feature is flaky #3464

Closed
johnjbarton opened this issue Apr 9, 2020 · 2 comments · Fixed by karronoli/redpen#10 · 4 remaining pull requests
Closed

test/e2e/upstream-proxy.feature is flaky #3464

johnjbarton opened this issue Apr 9, 2020 · 2 comments · Fixed by karronoli/redpen#10 · 4 remaining pull requests
Labels
released

Comments

@johnjbarton
Copy link
Contributor

Seems to fail more than pass.

The failure call stack points to https://github.com/nodejs/node/blob/master/lib/_http_client.js#L435
indicating that socket was closed before a response was sent but without an error on the request.
@johnjbarton
Copy link
Contributor Author

The fail can be reproduced on some runs with just the single cucumber test running:
https://travis-ci.org/github/karma-runner/karma/jobs/673177446

Looks like the test is complete, the socket is still polling then the fail:

e2e/support/proxy match/__proxy__/__karma__/base/behind-proxy/test.js?d2eabc69ad6afb1becc3629a3e8aa460e8ea9d7f,__karma__/base/behind-proxy/test.js?d2eabc69ad6afb1becc3629a3e8aa460e8ea9d7f
e2e/support/proxy match/__proxy__/__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKI&sid=MZ-5KzqDoTQByb1KAAAA,__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKI&sid=MZ-5KzqDoTQByb1KAAAA
e2e/support/proxy match/__proxy__/__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKU&sid=MZ-5KzqDoTQByb1KAAAA,__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKU&sid=MZ-5KzqDoTQByb1KAAAA
e2e/support/proxy match/__proxy__/__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKe&sid=MZ-5KzqDoTQByb1KAAAA,__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKe&sid=MZ-5KzqDoTQByb1KAAAA
e2e/support/proxy match/__proxy__/__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKr&sid=MZ-5KzqDoTQByb1KAAAA,__karma__/socket.io/?EIO=3&transport=polling&t=N5WuCKr&sid=MZ-5KzqDoTQByb1KAAAA
F-e2e/support/proxy stop
e2e/support/proxy close
.

johnjbarton added a commit to johnjbarton/karma that referenced this issue Apr 9, 2020
@johnjbarton
fix(ci): stop the proxy before killing the child
904a080 
This should fix karma-runner#3464, hopefully. Since the test is flaky and only on Travis
we can't be sure until we try for awhile.
@johnjbarton johnjbarton mentioned this issue Apr 9, 2020
Closed
johnjbarton added a commit to johnjbarton/karma that referenced this issue Apr 13, 2020
@johnjbarton
fix(ci): stop the proxy before killing the child, handle errors
e4a4dc0 
This should fix karma-runner#3464, hopefully. Since the test is flaky and only on Travis
we can't be sure until we try for awhile.
johnjbarton added a commit to johnjbarton/karma that referenced this issue Apr 13, 2020
@johnjbarton
fix(ci): stop the proxy before killing the child, handle errors
17a8d42 
This should fix karma-runner#3464, hopefully. Since the test is flaky and only on Travis
we can't be sure until we try for awhile.
karmarunnerbot pushed a commit that referenced this issue Apr 16, 2020
@semantic-release-bot
chore(release): 5.0.2 [skip ci]
39648b5 
## [5.0.2](v5.0.1...v5.0.2) (2020-04-16)

### Bug Fixes

* **ci:** stop the proxy before killing the child, handle errors ([#3472](#3472)) ([abe9af6](abe9af6)), closes [#3464](#3464)
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jan 8, 2021
Open
Open
This was referenced May 27, 2021
Open
Open
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@loftyduck loftyduck mentioned this issue Nov 21, 2022
Open
@awaisab172 awaisab172 mentioned this issue Nov 22, 2022
Open
@enterstudio enterstudio mentioned this issue Nov 22, 2022
Open
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@johnjbarton @anthony-redFox
fix(ci): stop the proxy before killing the child, handle errors (karm…
3d3ce01 
…a-runner#3472)

This should fix karma-runner#3464, hopefully. Since the test is flaky and only on Travis
we can't be sure until we try for awhile.
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.2 [skip ci]
4b25c3b 
## [5.0.2](karma-runner/karma@v5.0.1...v5.0.2) (2020-04-16)

### Bug Fixes

* **ci:** stop the proxy before killing the child, handle errors ([karma-runner#3472](karma-runner#3472)) ([abe9af6](karma-runner@abe9af6)), closes [karma-runner#3464](karma-runner#3464)
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this issue Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this issue Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this issue Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@johnjbarton @karmarunnerbot