Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringify error on 'Cannot convert a Symbol value to a string' #2990

Merged
merged 1 commit into from May 28, 2018

Conversation

Xesenix
Copy link
Contributor

@Xesenix Xesenix commented May 6, 2018

There were problems with using console.log while running test that resulted in errors like:

Chrome 66.0.3359 (Windows 7.0.0) moves should move rock box player up if they are adjacent one over each other FAILED
        TypeError: Cannot convert a Symbol value to a string
            at <Jasmine>
            at ContextKarma.stringify (http://localhost:9876/context.js:1804:34) // here stringify
            at ContextKarma.log (http://localhost:9876/context.js:1867:24)
            at <Jasmine>
            at Algorithm.resolveCell (src/game-00/main.test.ts:214654:13)
            at ordered.filter.obj (src/game-00/main.test.ts:214613:42)
            at <Jasmine>
            at Algorithm.update (src/game-00/main.test.ts:214613:23)
            at UserContext.it (src/game-00/main.test.ts:214494:19)

or

TypeError: Cannot convert a Symbol value to a string
        at ContextKarma.stringify (context.js:75:34) // here stringify
        at ContextKarma.log (context.js:138:24)
        at console.localConsole.(anonymous function) [as log] (context.js:242:16)
        at Context.<anonymous> (test.webpack.js:9:576885)

Related to issue: #2856

I have also noticed that i need to remove static/context.js and static/karma.js from .gitignore and include them in the repo so that this fix worked on my repository copy but didn't include it here as I am not sure they are built at some later point.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Xesenix
Copy link
Contributor Author

Xesenix commented May 6, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the first characters of your description to
fix(common):
Please add to your commit description
Fixes #2856
Please rebase and push again to trigger a retest.

@Xesenix Xesenix force-pushed the fix-stringify branch 3 times, most recently from fc0d4ab to 5763c5e Compare May 27, 2018 02:13
@Xesenix
Copy link
Contributor Author

Xesenix commented May 28, 2018

@johnjbarton fixed issues test are passing tell me if you need anything more

@johnjbarton johnjbarton merged commit 65b658a into karma-runner:master May 28, 2018
@johnjbarton
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants