Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma doesn't clean up Socket.IO listeners when exiting #2980

Closed
briandipalma opened this issue Apr 23, 2018 · 0 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Karma doesn't clean up Socket.IO listeners when exiting #2980

briandipalma opened this issue Apr 23, 2018 · 0 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@briandipalma
Copy link
Contributor

Expected behaviour

Karma should clean up resources when exiting.

Actual behaviour

It doesn't.

Environment Details

  • Karma version (output of karma --version): 2.0.0
  • Relevant part of your karma.config.js file

Steps to reproduce the behaviour

  1. Use Karma API to create Server after Server
  2. Watch memory grow after each run.
  3. Node dies.

PR incoming, just needed a GitHub issue.
briandipalma added a commit to briandipalma/karma that referenced this issue Apr 23, 2018
@briandipalma
fix(server): Remove Socket.IO listeners
10993bd 
Not removing Socket.IO listeners can cause memory issues
in long running processes that spawn many Karma instance.

Fixes karma-runner#2980
@briandipalma briandipalma mentioned this issue Apr 23, 2018
Merged
@rsimha rsimha mentioned this issue Apr 23, 2018
Merged
briandipalma added a commit to briandipalma/karma that referenced this issue Apr 24, 2018
@briandipalma
fix(server): Remove Socket.IO listeners
b50d22d 
Not removing Socket.IO listeners can cause memory issues
in long running processes that spawn many Karma instance.

Fixes karma-runner#2980
briandipalma added a commit to briandipalma/karma that referenced this issue May 3, 2018
@briandipalma
fix(server): Remove Socket.IO listeners
c3f05ef 
Not removing Socket.IO listeners can cause memory issues
in long running processes that spawn many Karma instance.

Fixes karma-runner#2980
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@briandipalma