Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis build fail for firefox 59 #2957

Closed
jehon opened this issue Mar 14, 2018 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Travis build fail for firefox 59 #2957

jehon opened this issue Mar 14, 2018 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@jehon
Copy link

jehon commented Mar 14, 2018

Expected behaviour

Travis build should pass for firefox 59. It did for firefox 58

Actual behaviour

The test fail with:

1) Scenario: Execute a test in Firefox with version, with JavaScript tag # test/e2e/tag.feature:6
   ✔ Given a configuration with: # test/e2e/step_definitions/core_steps.js:116
[...]
  ✖ Then it passes with: # test/e2e/step_definitions/core_steps.js:185
       """
       .
       Firefox
       """
       Error: Expected output to match the following:
         .
       Firefox
       Got:
         Firefox 59.0.0 (Linux 0.0.0) ERROR
         {
           "message": "You need to include some adapter that implements _karma_.start method!",
           "str": "You need to include some adapter that implements _karma_.start method!"
         }
       Firefox 59.0.0 (Linux 0.0.0): Executed 0 of 0 ERROR (0.196 secs / 0 secs)

Environment Details

  • Karma version (output of karma --version): 2.0.0 (checkout of master at 2018-03-14 22:11 European time)
  • Relevant part of your karma.config.js file: NA

Steps to reproduce the behaviour

  1. clone the karma-runner/karma repository
  2. npm install && npm link :-)
  3. npm test

Additionnal notes

Firefox 59 has dropped the "version tag" in its scripts, and I think that it leads to this error.
See:

@jehon
Copy link
Author

jehon commented Mar 14, 2018

Details could be viewed here:
https://travis-ci.org/karma-runner/karma/jobs/353527744

even though it is a pull request linked to my dev

@jehon
Copy link
Author

jehon commented Mar 14, 2018

The bug is visible in #2956

I did reproduce it locally:

  • with ubuntu firefox 58, tests are passing
  • with fresh download of firefox 59 (tar.bz2), same tests are not passing anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant