Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usePolling should be false for newer macOS? #2669

Closed
michaelsbradleyjr opened this issue Apr 20, 2017 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

usePolling should be false for newer macOS? #2669

michaelsbradleyjr opened this issue Apr 20, 2017 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@michaelsbradleyjr
Copy link

michaelsbradleyjr commented Apr 20, 2017 •
edited

See: https://github.com/karma-runner/karma/blob/master/lib/config.js#L318

tracking it back w/ blame:

66f50d7

66f50d7#commitcomment-21831412

On current macOS (I'm running 10.12.4, for example) setting usePolling to false works much better than having it set true, and the CPU utilization is dramatically lower. I'm running node v7.9.0, latest releases of karma, etc.
@michaelsbradleyjr michaelsbradleyjr mentioned this issue Apr 20, 2017
Closed
3 tasks
@wesleycho
Copy link
Member

Thoughts on this @dignifiedquire? Sounds like it might be reasonable to change this and releasing a hotfix if it becomes an issue again.

@dignifiedquire
Copy link
Member

I haven't tested it myself, but I am okay changing the default with 2.0.

wesleycho added a commit to wesleycho/karma that referenced this issue May 6, 2017
@wesleycho
feat(config): remove polling usage
b0f41c7 
- Remove polling usage for file change watching with chokidar on Mac OS

Closes karma-runner#2669
@wesleycho wesleycho mentioned this issue May 6, 2017
Merged
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michaelsbradleyjr @dignifiedquire @wesleycho