Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete browser log output when process isn't started #2663

Closed
LoveIsGrief opened this issue Apr 16, 2017 · 1 comment
Closed

Complete browser log output when process isn't started #2663

LoveIsGrief opened this issue Apr 16, 2017 · 1 comment

Comments

@LoveIsGrief
Copy link
Contributor

LoveIsGrief commented Apr 16, 2017 •
edited

I was working on litixsoft/karma-detect-browsers#22 and travis isn't able to start Chromium successfully (logs).

lamb sauce1

The process exits "successfully", yet too early and I have no idea why. I cannot recreate it locally and am lacking the logs to investigate. So this is just a feature request to help debugging.

Expected behaviour

Logs as to why the process exited

Actual behaviour

No logs

Environment Details

  • Karma version (output of karma --version): taken from package.json "karma": "^0.13.22"
  • Relevant part of your karma.config.js file
    I don't know what's relevant so here's the whole thing karma.conf.js

Steps to reproduce the behaviour

I'm not able to reproduce locally, but see the travis logs. I guess one could:

  1. create an executable dummy script that simply outputs rubbish and exits with 0
  2. name the script chromium-browser
  3. add the location of the script as the first element in PATH
  4. npm install -D karma-chrome-launcher
  5. Add karma-chrome-launcher to the karma.conf.js
  6. launch karma with and watch it fail without logs
LoveIsGrief pushed a commit to LoveIsGrief/karma that referenced this issue Apr 16, 2017
feat(runner): Buffer stdout and stderr for output when errors occur
e2b61eb 
When it is determined that an error occured during the run of a launch
it's useful to have output from the process.
We just need to know what was going on in order to debug (if necessary)

Related to karma-runner#2663 Complete browser log output when process isn't started
@LoveIsGrief LoveIsGrief mentioned this issue Apr 17, 2017
Merged
LoveIsGrief pushed a commit to LoveIsGrief/karma that referenced this issue Apr 18, 2017
feat(runner): Buffer stdout and stderr for output when errors occur
460d423 
When it is determined that an error occured during the run of a launch
it's useful to have output from the process.
We just need to know what was going on in order to debug (if necessary)

Related to karma-runner#2663 Complete browser log output when process isn't started
@wesleycho
Copy link
Member

@dignifiedquire can this issue be closed? Looks like the referenced PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dignifiedquire @wesleycho @LoveIsGrief