Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware is created before all plugins are loaded #1972

Closed
dignifiedquire opened this issue Mar 7, 2016 · 0 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Middleware is created before all plugins are loaded #1972

dignifiedquire opened this issue Mar 7, 2016 · 0 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Assignees
@dignifiedquire
Labels
type: bug
Milestone
v1.0

Comments

@dignifiedquire
Copy link
Member

Expected behavior

Plugins should be able to change the configuration before it's used.

Actual behavior

Karma instantiates the middleware in lib/web-server.js before plugins are loaded, and does not update the config on request, resulting in issues like #1957 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
type: bug
Projects
None yet
Milestone
v1.0
1 participant
@dignifiedquire