Feature adding no colors to run command #1791
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Thanks, could please try either cherry-picking your commits into a new branch, or rebasing this one onto master as there seem to be some conflicts at the moment and it's hard to review like this. |
budde377
force-pushed
the
feature-adding-no-colors-to-run-command
branch
from
2893930
to
7b9fa96
Compare
|
CLAs look good, thanks! |
|
Here you go! |
|
This will need some merging with master please |
|
Yes, will do this afternoon. On Tue, Jan 19, 2016, 22:23 Friedel Ziegelmayer notifications@github.com
|
Add colors and log-level arguments to run argument. Refactor log-setup functions for server and init. Correct bug in server where log-level was ignored before `parseConfig` Closing karma-runner#1067
Delay the decision on color/no-color reporter to write. This is done by letting the individual adapter decide the color and providing a default color to the base adapter. Closing karma-runner#1067
budde377
force-pushed
the
feature-adding-no-colors-to-run-command
branch
from
7b9fa96
to
486c4f3
Compare
|
Well, its afternoon somewhere. Here you go! |
|
Thanks |
you rock!…n-command Feature adding no colors to run command
…dding-no-colors-to-run-command" Fixes karma-runner#1894, karma-runner#1895 This reverts commit 56073fc, reversing changes made to b7d591f.
…dding-no-colors-to-run-command" This reverts commit 56073fc, reversing changes made to b7d591f. This reverts commit 56073fc, reversing changes made to b7d591f. Fixes karma-runner#1894, karma-runner#1895
…dding-no-colors-to-run-command" This reverts commit 56073fc, reversing changes made to b7d591f. Fixes karma-runner#1894, karma-runner#1895
revert: "Merge pull request #1791 from budde377/feature-adding-no-col…
This will solve #1067 but also make some quite invasive changes. Including changing the constructor of the std. reporters. Since these should be generated with injection (according to this todo) this might not be such a big change after all.
Furthermore this allows setting the
colorproperties on an adapter for deciding if a given reporter should write to it.