Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if full page reload error is obsolete #1656

Closed
nebulou5 opened this issue Oct 22, 2015 · 9 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Determine if full page reload error is obsolete #1656

nebulou5 opened this issue Oct 22, 2015 · 9 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@nebulou5
Copy link
Contributor

@dignifiedquire After the previous fixes to the reloadingContext flag, I'm unable to trigger the full page reload error at all regardless of what I put in my jasmine tests. I've tried causing a page reload via window.location.reload(), window.location.href = '', window.location.assign, etc... None of these trigger the error.

Did our fixes to the reloadingContext flag break some important behavior? Or is the full page reload error (Some of your tests did a full page reload!) now obsolete?

@dignifiedquire
Copy link
Member

No it's not obsolete, if that is the case that means our fixes our not working as intended. I'm afraid I will have to roll back to the earlier version then for now until we figure out a better way :(

@nebulou5
Copy link
Contributor Author

@dignifiedquire This appears to be an issue with jasmine-core. Refer to jasmine/jasmine#366 and jasmine/jasmine#945

@dignifiedquire
Copy link
Member

@FuzzySockets thanks for digging into this!

@adjavaherian
Copy link

So, it looks like a jasmine-core issue? I'm seeing this on one environment but not another.
http://stackoverflow.com/questions/35189214/karma-sauce-labs-test-failing-in-one-environment

@adambiggs
Copy link

I'm seeing this issue intermittently from Chrome when running a large (5000+) test suite in multiple browsers (Chrome, Firefox, and PhantomJS). Using the latest version of Karma.

@shaharmor
Copy link
Contributor

Hi, is there any intention to do this today? I am seeing this error when using Karma + Mocha as well.
The tests are all passing but somewhere in the middle i (sometimes) see a "Page reload" error which causes the entire suite to fail even though all tests passed.
Can we somehow make Karma just return the correct exit code and ignore this error?

@madnight
Copy link
Contributor

I found something interesting if you run the tests separate:

- npm run test  # firefox, phantom, .... all you like execpt chrome
- npm run test-travis-chrome # only chrome

then this page reload error does not occur, however this solution results in longer test run times, since they are executed twice

@madnight
Copy link
Contributor

Chromium 37.0.2062 (Ubuntu 0.0.0) ERROR Some of your tests did a full page reload!

still an issue

@devoto13
Copy link
Collaborator

This sounds like a valid bug to me. However, there have been many changes to the library since it was reported. Please open a new issue including a minimal reproduction if you still experience this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants