Static binary assets are not served correctly when they have capital letters in extension

[lonelyelk]

When serving static binary assets configured with:

files: [
    ...
    {pattern: './fixtures/images/*.jpg', included: false, served: true},
    {pattern: './fixtures/images/*.JPG', included: false, served: true},
    ...
]

Only images with *.jpg extensions are served properly. Capital letters extension shows a 'broken image' icon. This seems to be due to not recognising said image as a binary file. Adding "JPG" to lib/binary-extensions.json or modifying lib/preprocessor.js condition like so:

var thisFileIsBinary = isBinary[path.extname(file.originalPath).toLowerCase()]

Solves the problem.

Not sure how to write a failing test for this to submit a fix.

[dignifiedquire]

You can add a test here:

karma/test/unit/preprocessor.spec.coffee

Line 182 in 8a9c8c7

it 'should not preprocess binary files', (done) ->

and add a file with an upper case extension here

karma/test/unit/preprocessor.spec.coffee

Line 6 in 8a9c8c7

di = require 'di'

[lonelyelk]

Current master branch has failing tests for me before I even started editing both under node v0.12.6 and iojs v2.3.3:

$ grunt
Running "browserify:client" (browserify) task
>> Bundle static/karma.js created.

Running "test:unit" (test) task

Running "mochaTest:unit" (mochaTest) task


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  377 passing (5s)
  3 pending


Running "test:client" (test) task
Running /Users/kruk/dev/karma/bin/karma start test/client/karma.conf.js --single-run --no-auto-watch --reporters=dots
failed to add custom browserify preprocessor
{ [Error: Cannot find module 'karma/lib/preprocessor'] code: 'MODULE_NOT_FOUND' }
22 07 2015 00:05:14.797:INFO [framework.browserify]: 472361 bytes written (0.87 seconds)
22 07 2015 00:05:14.808:INFO [karma]: Karma v0.13.2 server started at http://localhost:9876/
22 07 2015 00:05:14.814:INFO [launcher]: Starting browser Chrome
22 07 2015 00:05:16.157:INFO [Chrome 43.0.2357 (Mac OS X 10.10.4)]: Connected on socket rTnfwhUtnLPRh4G1AAAA with id 19490884
Chrome 43.0.2357 (Mac OS X 10.10.4) ERROR
  Uncaught ReferenceError: require is not defined
  at /Users/kruk/dev/karma/test/client/karma.spec.js:1
Chrome 43.0.2357 (Mac OS X 10.10.4): Executed 0 of 0 ERROR (0.162 secs / 0 secs)
[Error: failed to add custom browserify preprocessor
{ [Error: Cannot find module 'karma/lib/preprocessor'] code: 'MODULE_NOT_FOUND' }]
Fatal error: Client unit tests failed.

[dignifiedquire]

You'll need to run these commands first https://github.com/karma-runner/karma/blob/master/.travis.yml#L23-L24