Socketio 1.1 new #1258
Closed
Socketio 1.1 new #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhimil Looks like this needs to be rebased. Can any of the maintainers review this? @karmarunnerbot |
|
@dhimil Thanks! Can you rebase on master, squash commits to one and change commit message following git commit message convention |
| @@ -264,7 +264,6 @@ var createSocketIoServer = function(webServer, executor, config) { | |||
| 'client store expiration': 0, | |||
| logger: logger.create('socket.io', constant.LOG_ERROR), | |||
| resource: config.urlRoot + 'socket.io', | |||
| transports: config.transports | |||
There was a problem hiding this comment.
@dhimil Why we remove transports?
New version of socket.io does not allow setup transport?
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 15, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 15, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 17, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 17, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 17, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
|
Superseded by #1404 |
lygstate
pushed a commit
to lygstate/karma
that referenced
this pull request
May 27, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this pull request
May 27, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
shirish87
pushed a commit
to shirish87/karma
that referenced
this pull request
Aug 29, 2015
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220. Conflicts: package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.