Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setTimout in socket.io prevents Karma from exiting on Windows #1109

Closed
pkozlowski-opensource opened this issue Jun 25, 2014 · 0 comments · Fixed by #1121 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

setTimout in socket.io prevents Karma from exiting on Windows #1109

pkozlowski-opensource opened this issue Jun 25, 2014 · 0 comments · Fixed by #1121 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
priority: high

Comments

@pkozlowski-opensource
Copy link
Member

Taken from karma-runner/gulp-karma#5

There is a setTimeout in socket.io (https://github.com/Automattic/socket.io/blob/0.9/lib/transport.js#L216) that prevents Karma from exiting. Interestingly this timeout prevents Karma from exiting on Windows only, OSX and Linux is not affected.

Yesterday my colleague have discovered that this could be worked-around by explicitly disconnecting each socket on Karma exit (basically adding sockets[key].disconnect() here: https://github.com/karma-runner/karma/blob/v0.12.16/lib/server.js#L201). I'm not familiar with the socket.io internals well enough so I'm not sure if this is the right thing to do, but I'm kind of loosing hope of having any fixes done in the socket.io version that Karma is using atm.

Would be grateful for any input here, especially from the ones knowing karma + socket.io interactions a bit better.
Closed
@pkozlowski-opensource pkozlowski-opensource changed the title setTimout in socket.io prevents Karma from existing on Windows setTimout in socket.io prevents Karma from exiting on Windows Jul 1, 2014
bcharbonnier added a commit to bcharbonnier/karma that referenced this issue Jul 1, 2014
@bcharbonnier
fix(server): Force clients disconnect on Windows
83b1a48 
It occurs that only on Windows, socket.io clients are not properly disconnected, which causes Karma to not exit immediately when everything is done. We have to wait for some internal disconnection socket.io event timeout.

This PR basically check if all sockets are disconnected. If not we manually force the disconnection.

Fixes karma-runner#1109
@bcharbonnier bcharbonnier mentioned this issue Jul 1, 2014
Merged
bcharbonnier added a commit to bcharbonnier/karma that referenced this issue Jul 1, 2014
@bcharbonnier
fix(server): Force clients disconnect on Windows
28239f4 
It occurs that only on Windows, socket.io clients are not properly disconnected, which causes Karma to not exit immediately when everything is done. We have to wait for some internal disconnection socket.io event timeout.

This PR basically check if all sockets are disconnected. If not we manually force the disconnection.

Fixes karma-runner#1109
@kaelig kaelig mentioned this issue Aug 6, 2014
Merged
This was referenced Sep 27, 2018
Merged
Closed
This was referenced May 25, 2019
Closed
Merged
@renovate renovate bot mentioned this issue Sep 28, 2019
Merged
1 task
@renovate renovate bot mentioned this issue Oct 11, 2019
Merged
1 task
@cmorell cmorell mentioned this issue Jun 3, 2020
Open
1 task
@renovate renovate bot mentioned this issue Aug 19, 2020
Closed
1 task
@renovate renovate bot mentioned this issue Apr 6, 2021
Open
1 task
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
1 participant
@pkozlowski-opensource