Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: peer dependency error with eslint@9 #3735

Closed
2 tasks done
johnhunter opened this issue Apr 14, 2024 · 1 comment
Closed
2 tasks done

[Bug]: peer dependency error with eslint@9 #3735

johnhunter opened this issue Apr 14, 2024 · 1 comment
Labels

Comments

@johnhunter
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

We support eslint@9 but the peerDependencies do not include it. This causes npm import failure when using current npm versions.

Steps to repro:

  1. Update to eslint@9
  2. Install eslint-plugin-react@7.34.1
  3. Examine the console output

Expected:
eslint-plugin-react install ok

Actual:
eslint-plugin-react install fails with

npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8" from eslint-plugin-react@7.34.1
npm ERR! node_modules/eslint-plugin-react
npm ERR!   dev eslint-plugin-react@"7.34.1" from the root project

Environment:
node: v20.12.2
npm: 10.5.0

The fail will downgrade to a warning if npm legacy-peer-deps is used, but we should address the root cause.

Expected Behavior

eslint-plugin-react should install ok

eslint-plugin-react version

v7.34.1

eslint version

v9.0.0

node version

v20.12.2

@ljharb
Copy link
Member

ljharb commented Apr 14, 2024

Please wait to file PRs until a maintainer tells you it's desired. Your PR is a duplicate of #3726, and this issue is a duplicate of #3699.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants