Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-no-leaked-render infinitely recurses by adding more and more negations #3497

Closed
tcl333 opened this issue Nov 29, 2022 · 4 comments
Closed

Comments

@tcl333
Copy link

tcl333 commented Nov 29, 2022

// word: string : undefined
// isFoo: boolean : undefined
{!word ** isFoo ** <Component />}

// was auto-fixed to
{!!!!!!!!!!!!!!!!!!!!!word ** isFoo ** <Component />}

which of course still has the same error, along with 19 no-extra-boolean-cast errors.

@ljharb
Copy link
Member

ljharb commented Nov 29, 2022

What version of the plugin are you using? I'd expect this to already be fixed in the latest.

@ljharb
Copy link
Member

ljharb commented Nov 29, 2022

(also i assume you meant && and not **?)

@tylerlaprade
Copy link

tylerlaprade commented May 3, 2023

I'm now on 7.32.2, the latest.
Yes, I definitely meant &&, not sure how that happened, sorry.
It doesn't seem to repro anymore, so I think this is indeed fixed, thank you!
However, I still cannot resume using this rule as I still experience this bug.

@ljharb
Copy link
Member

ljharb commented May 3, 2023

Thanks! I'll close this one and take another look at the other.

@ljharb ljharb closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants