Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jasmine global doesn't recognize spyOnProperty #3183

Closed
mikedaly opened this issue Sep 7, 2017 · 4 comments · May be fixed by ajesse11x/cjdns#1 or ajesse11x/amplify-js#5
Closed

Jasmine global doesn't recognize spyOnProperty #3183

mikedaly opened this issue Sep 7, 2017 · 4 comments · May be fixed by ajesse11x/cjdns#1 or ajesse11x/amplify-js#5
Labels
good first issue Has PR P4

Comments

@mikedaly
Copy link

mikedaly commented Sep 7, 2017 •
edited

Jasmine 2.6 added the ability to spy on properties via the new global, spyOnProperty. But JSHint's jasmine setting doesn't recognize that as a valid global.
@jugglinmike
Copy link
Member

Thanks for the report! The fix here is pretty straightforward--we'll just need to add an entry to the jasmin object in the vars.js source file. I'm marking this as low-priority, but I would gladly accept a patch introducing the new variable. Any chance you'd like to help out, @mikedaly?

@ebullient ebullient mentioned this issue Sep 15, 2017
Merged
@ebullient
Copy link

I'm your huckleberry. Happened to hit this today.

@mikedaly
Copy link
Author

@ebullient Does that mean you are putting up a PR? I was hoping to get to this later today, but don't want to duplicate effort.

@mikedaly
Copy link
Author

Doh - just saw that you already did. :)

jugglinmike pushed a commit that referenced this issue Oct 8, 2017
@jugglinmike
[[FIX]] recognize Jasmine global spyOnProperty
827237f 
Added `spyOnProperty` (introduced in Jasmine 2.6) to the list of known globals.

Fixes #3183
jugglinmike pushed a commit to jugglinmike/jshint that referenced this issue Oct 29, 2017
@jugglinmike
[[FIX]] recognize Jasmine global spyOnProperty
a664488 
Added `spyOnProperty` (introduced in Jasmine 2.6) to the list of known globals.

Fixes jshint#3183
This was referenced Oct 26, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Has PR P4
Projects
None yet
Milestone
No milestone
3 participants
@jugglinmike @ebullient @mikedaly