From 94774014e2244730f24d1fcb8c40d8fee3ea6b75 Mon Sep 17 00:00:00 2001 From: Zirro Date: Mon, 30 Jul 2018 21:11:18 +0200 Subject: [PATCH] Add window.status This was previously missing because it exposed a bug in the vm module on Node.js v6 which appeared in a few XHR tests. The bug has been fixed in later versions. --- lib/jsdom/browser/Window.js | 4 +--- .../the-window-object/window-properties-dont-upstream.html | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/jsdom/browser/Window.js b/lib/jsdom/browser/Window.js index 25bf579579..5194eb85ea 100644 --- a/lib/jsdom/browser/Window.js +++ b/lib/jsdom/browser/Window.js @@ -582,9 +582,7 @@ function Window(options) { define(this, { name: "", - // Node v6 has issues (presumably in the vm module) - // which this property exposes through an XHR test - // status: "", + status: "", devicePixelRatio: 1, innerWidth: 1024, innerHeight: 768, diff --git a/test/web-platform-tests/to-upstream/html/browsers/the-window-object/window-properties-dont-upstream.html b/test/web-platform-tests/to-upstream/html/browsers/the-window-object/window-properties-dont-upstream.html index d5a69eb010..113128a1e7 100644 --- a/test/web-platform-tests/to-upstream/html/browsers/the-window-object/window-properties-dont-upstream.html +++ b/test/web-platform-tests/to-upstream/html/browsers/the-window-object/window-properties-dont-upstream.html @@ -115,15 +115,15 @@ // "applicationCache", // not yet implemented // WindowSessionStorage - // "sessionStorage", // not yet implemented + "sessionStorage", // WindowLocalStorage - // "localStorage", // not yet implemented + "localStorage", ]; var writableAttributes = [ "name", -// "status", // looks like there is an issue with Node v6 and XHR, see Window.js + "status", // "opener", // not yet implemented "onabort", "onafterprint",