Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted primary color not updating #706

Labels

Comments

@rafaberaldo
Copy link
Contributor

First I want to thank you for the great framework! Love to use Bulma and I'm currently using it as a base for my Vuejs library.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version [0.4.1]
I am sure this issue is not a duplicate

Description

When customizing Bulma following the docs, if you change primary color for a light one (like #efecf4), the inverted color will not update to black.

Shouldn't these variables be like this (?):

$primary-invert: findColorInvert($primary) !default
$info-invert: findColorInvert($info) !default
$success-invert: findColorInvert($success) !default
$warning-invert: findColorInvert($warning) !default
$danger-invert: findColorInvert($danger) !default

Right now we have to import the entire bulma/sass/utilities/_all, get the inverted colors and put inside the $colors list.

Steps to Reproduce

@import "../sass/utilities/initial-variables"
$primary: #efecf4
@import "../bulma"

Expected behavior

Actual behavior

@herrmannplatz
Copy link

Run into the same issue. Definitely agree with @rafaelpimpa that the inverted color should be derived from the actual primary color and not from the default.

@rafaelpimpa would you like to create a PR? Otherwise a can do it.

And yeah great framework 🙌

@rafaberaldo
Copy link
Contributor Author

Go ahead :)

@stale
Copy link

stale bot commented Jan 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2019
@stale stale bot closed this as completed Jan 28, 2019
@snowman
Copy link

snowman commented Apr 14, 2019

set $turquoise: #efecf4 will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment