Hero Sizes should be configurable variables

[hammadzz]

Like done with section sass these hero sizes should be variables:

bulma/sass/layout/hero.sass

Lines 71 to 85 in 5381f26

	// Sizes
	&.is-small
	.hero-body
	padding-bottom: 1.5rem
	padding-top: 1.5rem
	&.is-medium
	+tablet
	.hero-body
	padding-bottom: 9rem
	padding-top: 9rem
	&.is-large
	+tablet
	.hero-body
	padding-bottom: 18rem
	padding-top: 18rem

See section sass:

bulma/sass/layout/section.sass

Lines 1 to 3 in 5381f26

	$section-padding: 3rem 1.5rem !default
	$section-padding-medium: 9rem 1.5rem !default
	$section-padding-large: 18rem 1.5rem !default

I can make a pull request on it if this seems like something many others would also want.

[IvanFrescas]

Hi, I'm looking to make my first contributions, can I work on this issue?

[kaleabMelkamu]

Yes ofcourse u can

…

On Sat, Dec 14, 2019, 7:45 AM IvanFrescas ***@***.***> wrote: Hi, I'm looking to make my first contributions, can I work on this issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2739?email_source=notifications&email_token=AKYT5LOBH4Y6E5GOHNA2YO3QYRQFVA5CNFSM4JZ53DH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG32ENA#issuecomment-565682740>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYT5LPO5EID5TTRWVHN5JLQYRQFVANCNFSM4JZ53DHQ> .

[IvanFrescas]

I made the changes and made the pull request.
Any feedback is welcome. 🙂