Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity to CLI prompt for where repository is hosted #103

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Add clarity to CLI prompt for where repository is hosted #103

merged 1 commit into from
Jul 16, 2018

Conversation

spencercorwin
Copy link
Contributor

Users, including myself, have put the wrong link in answer to "Where is the repository hosted?". This is a simple fix that should make it clearer what to input.

What: Changes prompts in the CLI to be more specific when asking for where the repository is hosted.

Why: This is necessary because users (including myself) have become confused on what to put for this. For example, I put "www.github.com/username/repository" for my use of all-contributors-cli, when it should only be the default "www.github.com".

How: Changes prompt to be more directional.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Users, including myself, have put the wrong link in answer to "Where is the repository hosted?"
@codecov-io
Copy link

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files          19       19           
  Lines         434      434           
  Branches       73       73           
=======================================
  Hits          251      251           
  Misses        152      152           
  Partials       31       31
Impacted Files Coverage Δ
src/init/prompt.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f671d...f0dd75c. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants