Skip to content

Commit

Permalink
feat: add new types (#127)
Browse files Browse the repository at this point in the history
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!

Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).

Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).

If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request

Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->

<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**:
Add Security contribution type, as mentioned in all-contributors/all-contributors#106 and implemented in all-contributors/all-contributors#107

Also added user-testing as introduced as part of https://github.com/kentcdodds/all-contributors/pull/97/files

<!-- Why are these changes necessary? -->
**Why**:
All contributors!

<!-- How were these changes implemented? -->
**How**:
Me

<!-- Have you done all of these things?  -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [x] Documentation
- [ ] Tests - N/A
- [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->

<!-- feel free to add additional comments -->
  • Loading branch information
jakebolam authored and Kent C. Dodds committed Jan 2, 2019
1 parent 2ade2d7 commit 89bac0f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -133,11 +133,13 @@ Where `username` is the user's GitHub or Gitlab username, and `contribution` is
- plugin: [🔌](# 'Plugin/utility libraries')
- question: [💬](# 'Answering Questions')
- review: [👀](# 'Reviewed Pull Requests')
- security: [🛡](# 'Security')
- talk: [📢](# 'Talks')
- test: [⚠️](# 'Tests')
- tool: [🔧](# 'Tools')
- translation: [🌍](# 'Translation')
- tutorial: [](# 'Tutorials')
- tutorial: [📓](# 'User Testing')
- video: [📹](# 'Videos')

Please note that if you are using a self-hosted gitlab instance, before adding
Expand Down
8 changes: 8 additions & 0 deletions src/util/contribution-types.js
Expand Up @@ -66,6 +66,10 @@ const defaultTypes = function(repoType) {
symbol: '👀',
description: 'Reviewed Pull Requests',
},
security: {
symbol: '🛡️',
description: 'Security',
},
talk: {
symbol: '📢',
description: 'Talks',
Expand All @@ -87,6 +91,10 @@ const defaultTypes = function(repoType) {
symbol: '✅',
description: 'Tutorials',
},
userTesting: {
symbol: '📓',
description: 'User Testing',
},
video: {
symbol: '📹',
description: 'Videos',
Expand Down

0 comments on commit 89bac0f

Please sign in to comment.