New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guard to arguments #58
Conversation
I'm getting an error `cannot read property [0] of undefined` point to `arguments` access here while using ESLint in VSCode, it seems like ESLint while running on incomplete code can call this with `arguments` undefined. Adding guard should fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run eslint --fix
and maybe adjust commit message?
@SimenB maybe we shouldn't fail the CI in such case as we can adjust the commit message before merging, or at least run it as a separate job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test which fails without this change
@thymikee Not sure I follow. |
This is what I meant 👍 |
@tinovyatkin ping 🙂Just adding a code snippet which shows the error you got would be great! |
The stack trace of the failure is
|
Great, thanks @steelbrain! Those indeed reproduced the issue, and the change in this PR fixes it. I added that as an assertion and will merge when CI is happy 🙂 |
🎉 This PR is included in version 22.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm getting an error
cannot read property [0] of undefined
point toarguments
access here while using ESLint in VSCode, it seems like ESLint while running on incomplete code can call this witharguments
undefined. Adding guard should fix that.