Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule - no-duplicate-hooks #298

Merged
merged 5 commits into from Jul 15, 2019
Merged

Conversation

Mark1626
Copy link
Contributor

Fix #231

Copy link
Member

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks really solid, thanks!

src/rules/util.js Outdated Show resolved Hide resolved
Copy link
Member

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
pinging @SimenB for a review as well

README.md Show resolved Hide resolved

const matchesTestFunction = object => object && testFunctions[object.name];
const matchesTestFunction = object => object && testFunctions.has(object.name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better, thanks!

@SimenB SimenB merged commit 3587240 into jest-community:master Jul 15, 2019
SimenB pushed a commit that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: no duplicated hooks
3 participants