refactor: use object destructuring for require statements

.eslintrc.js

@@ -1,11 +1,12 @@
 'use strict';
 
-const globals = require('./index').environments.globals.globals;
+const { globals } = require('./index').environments.globals;
 
 module.exports = {
   extends: [
     'eslint:recommended',
     'plugin:eslint-plugin/recommended',
+    'plugin:node/recommended',
     'prettier',
   ],
   plugins: ['eslint-plugin', 'node', 'prettier'],
@@ -22,6 +23,15 @@ module.exports = {
     'prefer-template': 'warn',
     'object-shorthand': ['warn', 'always', { avoidExplicitReturnArrows: true }],
     'node/no-unsupported-features': 'error',
+    'prefer-destructuring': [
+      'error',
+      {
+        VariableDeclarator: {
+          array: true,
+          object: true,
+        },
+      },
+    ],
     'prettier/prettier': 'error',
   },
   overrides: [

__tests__/rules.test.js

@@ -2,7 +2,7 @@
 
 const fs = require('fs');
 const path = require('path');
-const rules = require('../index').rules;
+const { rules } = require('../index');
 
 describe('rules', () => {
   it('should have a corresponding doc for each rule', () => {

processors/__tests__/snapshot-processor.test.js

@@ -12,7 +12,7 @@ describe('snapshot-processor', () => {
 
   describe('preprocess function', () => {
     it('should pass on untouched source code to source array', () => {
-      const preprocess = snapshotProcessor.preprocess;
+      const { preprocess } = snapshotProcessor;
       const sourceCode = "const name = 'johnny bravo';";
       const result = preprocess(sourceCode);
 
@@ -22,7 +22,7 @@ describe('snapshot-processor', () => {
 
   describe('postprocess function', () => {
     it('should only return messages about snapshot specific rules', () => {
-      const postprocess = snapshotProcessor.postprocess;
+      const { postprocess } = snapshotProcessor;
       const result = postprocess([
         [
           { ruleId: 'no-console' },

rules/__tests__/consistent-test-it.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../consistent-test-it');
 
 const ruleTester = new RuleTester({

rules/__tests__/expect-expect.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../expect-expect');
 
 const ruleTester = new RuleTester({

rules/__tests__/lowercase-name.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../lowercase-name');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-alias-methods.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-alias-methods');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-disabled-tests.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-disabled-tests');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-focused-tests.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-focused-tests');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-hooks.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-hooks');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-identical-title.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-identical-title');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-jasmine-globals.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-jasmine-globals');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-jest-import.test.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const rule = require('../no-jest-import.js');
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const ruleTester = new RuleTester();
 const message = `Jest is automatically in scope. Do not import "jest", as Jest doesn't export anything.`;
 

rules/__tests__/no-large-snapshots.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-large-snapshots');
 const noLargeSnapshots = rule.create;
 

rules/__tests__/no-test-callback.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-test-callback');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-test-prefixes.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-test-prefixes');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-test-return-statement.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-test-return-statement');
 
 const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2015 } });

rules/__tests__/prefer-expect-assertions.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-expect-assertions');
 
 const ruleTester = new RuleTester({

rules/__tests__/prefer-inline-snapshots.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-inline-snapshots');
 
 const ruleTester = new RuleTester();

rules/__tests__/prefer-spy-on.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-spy-on');
 
 const ruleTester = new RuleTester({

rules/__tests__/prefer-strict-equal.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-strict-equal');
 
 const ruleTester = new RuleTester();

rules/__tests__/prefer-to-be-null.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-to-be-null');
 
 const ruleTester = new RuleTester();

rules/__tests__/prefer-to-be-undefined.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-to-be-undefined');
 
 const ruleTester = new RuleTester();

rules/__tests__/prefer-to-contain.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-to-contain');
 
 const ruleTester = new RuleTester();

rules/__tests__/prefer-to-have-length.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../prefer-to-have-length');
 
 const ruleTester = new RuleTester();

rules/__tests__/require-tothrow-message.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../require-tothrow-message');
 
 const ruleTester = new RuleTester({

rules/__tests__/valid-describe.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../valid-describe');
 
 const ruleTester = new RuleTester({

rules/__tests__/valid-expect-in-promise.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../valid-expect-in-promise');
 
 const ruleTester = new RuleTester({

rules/__tests__/valid-expect.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../valid-expect');
 
 const ruleTester = new RuleTester();

rules/consistent-test-it.js

@@ -1,9 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
-const getNodeName = require('./util').getNodeName;
-const isTestCase = require('./util').isTestCase;
-const isDescribe = require('./util').isDescribe;
+const { getDocsUrl, getNodeName, isTestCase, isDescribe } = require('./util');
 
 module.exports = {
   meta: {

rules/expect-expect.js

@@ -5,8 +5,7 @@
  * MIT license, Remco Haszing.
  */
 
-const getDocsUrl = require('./util').getDocsUrl;
-const getNodeName = require('./util').getNodeName;
+const { getDocsUrl, getNodeName } = require('./util');
 
 module.exports = {
   meta: {

rules/lowercase-name.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
+const { getDocsUrl } = require('./util');
 
 const isItTestOrDescribeFunction = node => {
   return (
@@ -22,8 +22,8 @@ const isItDescription = node => {
 };
 
 const testDescription = node => {
-  const firstArgument = node.arguments[0];
-  const type = firstArgument.type;
+  const [firstArgument] = node.arguments;
+  const { type } = firstArgument;
 
   if (type === 'Literal') {
     return firstArgument.value;
@@ -74,7 +74,7 @@ module.exports = {
             data: { method: erroneousMethod },
             node,
             fix(fixer) {
-              const firstArg = node.arguments[0];
+              const [firstArg] = node.arguments;
               const description = testDescription(node);
 
               const rangeIgnoringQuotes = [

rules/no-alias-methods.js

@@ -1,8 +1,6 @@
 'use strict';
 
-const expectCase = require('./util').expectCase;
-const getDocsUrl = require('./util').getDocsUrl;
-const method = require('./util').method;
+const { expectCase, getDocsUrl, method } = require('./util');
 
 module.exports = {
   meta: {

rules/no-disabled-tests.js

@@ -1,7 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
-const getNodeName = require('./util').getNodeName;
+const { getDocsUrl, getNodeName } = require('./util');
 
 function collectReferences(scope) {
   const locals = new Set();

rules/no-focused-tests.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
+const { getDocsUrl } = require('./util');
 
 const testFunctions = Object.assign(Object.create(null), {
   describe: true,
@@ -27,7 +27,7 @@ module.exports = {
   },
   create: context => ({
     CallExpression(node) {
-      const callee = node.callee;
+      const { callee } = node;
 
       if (callee.type === 'MemberExpression') {
         if (

rules/no-hooks.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
+const { getDocsUrl } = require('./util');
 
 module.exports = {
   meta: {

rules/no-identical-title.js

@@ -1,8 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
-const isDescribe = require('./util').isDescribe;
-const isTestCase = require('./util').isTestCase;
+const { getDocsUrl, isDescribe, isTestCase } = require('./util');
 
 const newDescribeContext = () => ({
   describeTitles: [],

rules/no-jasmine-globals.js

@@ -1,7 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
-const getNodeName = require('./util').getNodeName;
+const { getDocsUrl, getNodeName } = require('./util');
 
 module.exports = {
   meta: {

rules/no-jest-import.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
+const { getDocsUrl } = require('./util');
 
 const message = `Jest is automatically in scope. Do not import "jest", as Jest doesn't export anything.`;
 

rules/no-large-snapshots.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getDocsUrl = require('./util').getDocsUrl;
+const { getDocsUrl } = require('./util');
 
 const reportOnViolation = (context, node) => {
   const lineLimit =