chore: clean up istanbul ignores (#397)

jest-community · Aug 15, 2019 · 189b5e7 · 189b5e7
1 parent 1b94f0e
commit 189b5e7
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/src/rules/no-test-callback.ts b/src/rules/no-test-callback.ts
@@ -37,7 +37,7 @@ export default createRule({
           fix(fixer) {
             const { body } = callback;
 
-            /* istanbul ignore if */
+            /* istanbul ignore if https://github.com/typescript-eslint/typescript-eslint/issues/734 */
             if (!body) {
               throw new Error(
                 `Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,

diff --git a/src/rules/prefer-to-have-length.ts b/src/rules/prefer-to-have-length.ts
@@ -58,7 +58,7 @@ export default createRule({
                 token => token.value === '.',
               );
 
-            /* istanbul ignore next */
+            /* istanbul ignore if */
             if (propertyDot === null) {
               throw new Error(
                 `Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,

diff --git a/src/rules/prefer-todo.ts b/src/rules/prefer-todo.ts
@@ -16,7 +16,7 @@ import {
 } from './tsUtils';
 
 function isFunctionBodyEmpty(node: FunctionExpression) {
-  /* istanbul ignore next https://github.com/typescript-eslint/typescript-eslint/issues/734 */
+  /* istanbul ignore if https://github.com/typescript-eslint/typescript-eslint/issues/734 */
   if (!node.body) {
     throw new Error(
       `Unexpected null while performing prefer-todo - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,

diff --git a/src/rules/tsUtils.ts b/src/rules/tsUtils.ts
@@ -225,7 +225,6 @@ export const isSupportedAccessor = <V extends string>(
 export const getAccessorValue = <S extends string = string>(
   accessor: AccessorNode<S>,
 ): S =>
-  /* istanbul ignore next */
   accessor.type === AST_NODE_TYPES.Identifier
     ? accessor.name
     : getStringValue(accessor);

diff --git a/src/rules/valid-expect-in-promise.ts b/src/rules/valid-expect-in-promise.ts
@@ -183,7 +183,7 @@ export default createRule<unknown[], MessageIds>({
         if (testFunction && !isHavingAsyncCallBackParam(testFunction)) {
           const { body } = testFunction;
 
-          /* istanbul ignore if */
+          /* istanbul ignore if https://github.com/typescript-eslint/typescript-eslint/issues/734 */
           if (!body) {
             throw new Error(
               `Unexpected null when attempting to fix ${context.getFilename()} - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,