Start linting all test/ files as part of test script (#704)

In an effort of ensuring consistent code style in test files as with
the "production" source code, we should run eslint as part of the
`$ npm test` script as well.

Most of the related fixes was done by `eslint` using the `--fix` argument.

Only special configuration tweaks for tests compared to the other
source code, is to allow functions declaration without names. The
rationale for allowing that in tests, is that the important reason we
have them in the source code (proper stacktraces) aren't as important
in test files.

package.json

@@ -32,7 +32,7 @@
     "npm": ">=1.4.0"
   },
   "scripts": {
-    "pretest": "eslint mustache.js bin/mustache",
+    "pretest": "eslint mustache.js bin/mustache test/**/*.js",
     "test": "mocha --reporter spec test/*-test.js",
     "test-render": "mocha  --reporter spec test/render-test",
     "pre-test-browser": "node test/create-browser-suite.js",

test/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "extends": "../.eslintrc",
+  "rules": {
+    "func-names": 0
+  }
+}

test/_files/ampersand_escape.js

@@ -1,3 +1,3 @@
 ({
-  message: "Some <code>"
-})
+  message: 'Some <code>'
+});

test/_files/apostrophe.js

@@ -1,4 +1,4 @@
 ({
   'apos': "'",
   'control': 'X'
-})
+});

test/_files/array_of_strings.js

@@ -1,3 +1,3 @@
 ({
   array_of_strings: ['hello', 'world']
-})
+});

test/_files/avoids_obj_prototype_in_view_cache.js

@@ -1,4 +1,4 @@
 ({
   valueOf: 'Avoids methods',
   watch: 'in Object.prototype'
-})
+});

test/_files/backslashes.js

@@ -1,3 +1,3 @@
 ({
-  value: "\\abc"
-})
+  value: '\\abc'
+});

test/_files/bug_11_eating_whitespace.js

@@ -1,3 +1,3 @@
 ({
-  tag: "yo"
-})
+  tag: 'yo'
+});

test/_files/bug_length_property.js

@@ -1,3 +1,3 @@
 ({
     length: 'hello'
-})
+});

test/_files/changing_delimiters.js

@@ -1,4 +1,4 @@
 ({
-  "foo": "foooooooooooooo",
-  "bar": "<b>bar!</b>"
-})
+  'foo': 'foooooooooooooo',
+  'bar': '<b>bar!</b>'
+});

test/_files/check_falsy.js

@@ -1,7 +1,7 @@
 ({
-  number: function(text, render) {
-    return function(text, render) {
+  number: function (text, render) {
+    return function (text, render) {
       return +render(text);
-    }
+    };
   }
-})
+});

test/_files/comments.js

@@ -1,5 +1,5 @@
 ({
   title: function () {
-    return "A Comedy of Errors";
+    return 'A Comedy of Errors';
   }
-})
+});

test/_files/complex.js

@@ -1,19 +1,19 @@
 ({
   header: function () {
-    return "Colors";
+    return 'Colors';
   },
   item: [
-      {name: "red", current: true, url: "#Red"},
-      {name: "green", current: false, url: "#Green"},
-      {name: "blue", current: false, url: "#Blue"}
+      {name: 'red', current: true, url: '#Red'},
+      {name: 'green', current: false, url: '#Green'},
+      {name: 'blue', current: false, url: '#Blue'}
   ],
   link: function () {
-    return this["current"] !== true;
+    return this['current'] !== true;
   },
   list: function () {
     return this.item.length !== 0;
   },
   empty: function () {
     return this.item.length === 0;
   }
-})
+});

test/_files/context_lookup.js

@@ -1,8 +1,8 @@
 ({
-  "outer": {
-    "id": 1,
-    "second": {
-      "nothing": 2
+  'outer': {
+    'id': 1,
+    'second': {
+      'nothing': 2
     }
   }
-})
+});

test/_files/delimiters.js

@@ -1,6 +1,6 @@
 ({
-  first: "It worked the first time.",
-  second: "And it worked the second time.",
-  third: "Then, surprisingly, it worked the third time.",
-  fourth: "Fourth time also fine!."
-})
+  first: 'It worked the first time.',
+  second: 'And it worked the second time.',
+  third: 'Then, surprisingly, it worked the third time.',
+  fourth: 'Fourth time also fine!.'
+});

test/_files/disappearing_whitespace.js

@@ -1,4 +1,4 @@
 ({
   bedrooms: true,
   total: 1
-})
+});

test/_files/dot_notation.js

@@ -1,6 +1,6 @@
 ({
-  name: "A Book",
-  authors: ["John Power", "Jamie Walsh"],
+  name: 'A Book',
+  authors: ['John Power', 'Jamie Walsh'],
   price: {
     value: 200,
     vat: function () {
@@ -13,12 +13,12 @@
   },
   availability: {
     status: true,
-    text: "In Stock"
+    text: 'In Stock'
   },
   // And now, some truthy false values
   truthy: {
     zero: 0,
     notTrue: false
   },
-  singletonList: [{singletonItem: "singleton item"}]
-})
+  singletonList: [{singletonItem: 'singleton item'}]
+});

test/_files/double_render.js

@@ -1,5 +1,5 @@
 ({
   foo: true,
-  bar: "{{win}}",
-  win: "FAIL"
-})
+  bar: '{{win}}',
+  win: 'FAIL'
+});

test/_files/empty_list.js

@@ -1,3 +1,3 @@
 ({
   jobs: []
-})
+});

test/_files/empty_sections.js

@@ -1 +1 @@
-({})
+({});

test/_files/empty_string.js

@@ -1,6 +1,6 @@
 ({
-  description: "That is all!",
+  description: 'That is all!',
   child: {
-    description: ""
+    description: ''
   }
-})
+});

test/_files/empty_template.js

@@ -1 +1 @@
-({})
+({});

test/_files/error_not_found.js

@@ -1,3 +1,3 @@
 ({
   bar: 2
-})
+});

test/_files/escaped.js

@@ -1,7 +1,7 @@
 ({
   title: function () {
-    return "Bear > Shark";
+    return 'Bear > Shark';
   },
   symbol: null,
   entities: "&quot; \"'<>`=/"
-})
+});

test/_files/falsy.js

@@ -1,8 +1,8 @@
 ({
-  "emptyString": "",
-  "emptyArray": [],
-  "zero": 0,
-  "null": null,
-  "undefined": undefined,
-  "NaN": 0/0
-})
+  'emptyString': '',
+  'emptyArray': [],
+  'zero': 0,
+  'null': null,
+  'undefined': undefined,
+  'NaN': 0/0
+});

test/_files/falsy_array.js

@@ -1,10 +1,10 @@
 ({
-  "list": [
-  	["", "emptyString"],
-  	[[], "emptyArray"],
-  	[0, "zero"],
-  	[null, "null"],
-  	[undefined, "undefined"],
-  	[0/0, "NaN"]
+  'list': [
+		['', 'emptyString'],
+		[[], 'emptyArray'],
+		[0, 'zero'],
+		[null, 'null'],
+		[undefined, 'undefined'],
+		[0/0, 'NaN']
   ]
-})
+});

test/_files/grandparent_context.js

@@ -16,4 +16,4 @@
       ]
     }
   ]
-})
+});

test/_files/higher_order_sections.js

@@ -1,9 +1,9 @@
 ({
-  name: "Tater",
-  helper: "To tinker?",
+  name: 'Tater',
+  helper: 'To tinker?',
   bolder: function () {
     return function (text, render) {
       return text + ' => <b>' + render(text) + '</b> ' + this.helper;
-    }
+    };
   }
-})
+});

test/_files/implicit_iterator.js

@@ -5,4 +5,4 @@
       name: 'janl'
     }
   }
-})
+});

test/_files/included_tag.js

@@ -1,3 +1,3 @@
 ({
-  html: "I like {{mustache}}"
-})
+  html: 'I like {{mustache}}'
+});

test/_files/inverted_section.js

@@ -1,3 +1,3 @@
 ({
-  "repos": []
-})
+  'repos': []
+});

test/_files/keys_with_questionmarks.js

@@ -1,5 +1,5 @@
 ({
-  "person?": {
-    name: "Jon"
+  'person?': {
+    name: 'Jon'
   }
-})
+});

test/_files/malicious_template.js

@@ -1 +1 @@
-({})
+({});

test/_files/multiline_comment.js

@@ -1 +1 @@
-({})
+({});

test/_files/nested_dot.js

@@ -1 +1 @@
-({ name: 'Bruno' })
+({ name: 'Bruno' });

test/_files/nested_iterating.js

@@ -5,4 +5,4 @@
       bar: 'bar'
     }]
   }]
-})
+});

test/_files/nesting.js

@@ -4,4 +4,4 @@
     {a: {b: 2}},
     {a: {b: 3}}
   ]
-})
+});

test/_files/nesting_same_name.js

@@ -5,4 +5,4 @@
       items: [1, 2, 3, 4]
     }
   ]
-})
+});

test/_files/null_lookup_array.js

@@ -1,9 +1,9 @@
 ({
-    "name": "David",
-    "twitter": "@dasilvacontin",
-    "farray": [
-    	["Flor", "@florrts"],
-    	["Miquel", null],
-    	["Chris", undefined]
-    ]
-})
+  'name': 'David',
+  'twitter': '@dasilvacontin',
+  'farray': [
+    ['Flor', '@florrts'],
+    ['Miquel', null],
+    ['Chris', undefined]
+  ]
+});

test/_files/null_lookup_object.js

@@ -1,31 +1,31 @@
 ({
-  "name": "David",
-  "twitter": "@dasilvacontin",
-  "fobject": [
+  'name': 'David',
+  'twitter': '@dasilvacontin',
+  'fobject': [
     {
-      "name": "Flor",
-      "twitter": "@florrts"
+      'name': 'Flor',
+      'twitter': '@florrts'
     },
     {
-      "name": "Miquel",
-      "twitter": null
+      'name': 'Miquel',
+      'twitter': null
     },
     {
-	"name": "Chris",
-	"twitter": undefined
+	'name': 'Chris',
+	'twitter': undefined
     }
   ],
-  "favorites": {
-    "color": "blue",
-    "president": "Bush",
-    "show": "Futurama"
+  'favorites': {
+    'color': 'blue',
+    'president': 'Bush',
+    'show': 'Futurama'
   },
-  "mascot": {
-    "name": "Squid",
-    "favorites": {
-      "color": "orange",
-      "president": undefined,
-      "show": null
+  'mascot': {
+    'name': 'Squid',
+    'favorites': {
+      'color': 'orange',
+      'president': undefined,
+      'show': null
     }
   }
-})
+});