feat(gao-de-location): add plugin #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
added
the
target: patch
danielsogl
changed the title
danielsogl
requested changes
Dec 28, 2018
| * @returns {Promise<any>} Returns a Promise that resolves with the success return, or rejects with an error. | ||
| */ | ||
| @Cordova() | ||
| getCurrentPosition(): Promise<any> { |
There was a problem hiding this comment.
Please provide the correct typings as an interface.
| */ | ||
| @Plugin({ | ||
| pluginName: 'GaoDeLocation', | ||
| plugin: 'cordova-plugin-gaodelocation-chenyu', // npm package name, example: cordova-plugin-camera |
There was a problem hiding this comment.
Remove the placeholder comments
| /** | ||
| * @name Gao De Location | ||
| * @description | ||
| * Get the current location |
There was a problem hiding this comment.
Please provide a better description. I'm not that familiar with Chinese so I don't know the difference between this plugin and the Cordova geolocation plugin.
waliu
commented
Dec 29, 2018
danielsogl
approved these changes
Dec 29, 2018
|
Do you need any other changes? |
|
No its fine. I will merge all open PR's tomorrow. |
This was referenced Feb 23, 2020
This was referenced Mar 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
�Through this plug-in, you can get the local location. Reverse Address Coding