From c324c620e865a9f27f41b63492d8808e24b88d3d Mon Sep 17 00:00:00 2001 From: Nik Polyakov Date: Sun, 10 Dec 2017 19:45:21 +0200 Subject: [PATCH] Update portfinder to convert option.port to number MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi! Got a strange error while working on an angular app. For some reason, when I try to get the server up it throws the error below. Obviously, when it receives '8080', everything crashes and according to exports.basePort options.port always should be of a number type. ~ ng s │net.js:1487 │ throw new errors.RangeError('ERR_SOCKET_BAD_PORT', options.port); │ ^ │ │RangeError [ERR_SOCKET_BAD_PORT]: Port should be > 0 and < 65536. Received 80801. │ at Server.listen (net.js:1487:13) │ at Object.internals.testPort (//node_modules/portfinder/lib/portfinder.js:69:18 │) │ at Server.onError (//node_modules/portfinder/lib/portfinder.js:60:15) │ at Object.onceWrapper (events.js:254:19) │ at Server.emit (events.js:159:13) │ at emitErrorNT (net.js:1387:8) │ at _combinedTickCallback (internal/process/next_tick.js:138:11) │ at process._tickCallback (internal/process/next_tick.js:180:9) --- lib/portfinder.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/portfinder.js b/lib/portfinder.js index 89c1d6b..8102c42 100644 --- a/lib/portfinder.js +++ b/lib/portfinder.js @@ -27,9 +27,9 @@ internals.testPort = function(options, callback) { options = {}; } - options.port = options.port || exports.basePort; - options.host = options.host || null; - options.server = options.server || net.createServer(function () { + options.port = +options.port || exports.basePort; + options.host = options.host || null; + options.server = options.server || net.createServer(function () { // // Create an empty listener for the port testing server. //