Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(devtools): update references to Runtime.cachedResources #9758

Merged

Conversation

TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Sep 30, 2019

These references will be properly namespace-scoped once https://chromium-review.googlesource.com/c/1829708 is submitted.

@TimvdLippe TimvdLippe changed the title Update references to Runtime.cachedResources misc: Update references to Runtime.cachedResources Sep 30, 2019
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping us up to date

r: @connorjclark

@brendankenny brendankenny changed the title misc: Update references to Runtime.cachedResources clients(devtools): update references to Runtime.cachedResources Sep 30, 2019
@connorjclark connorjclark merged commit dff20c5 into GoogleChrome:master Sep 30, 2019
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@paulirish
Copy link
Member

@TimvdLippe it looks like in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107523 these changes effectively reverted. so we're still using globalThis.Runtime.cachedResources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants