fix: fix with --dry-run should not modify files #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on a few more tests |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 97.01% 97.23% +0.21%
==========================================
Files 10 10
Lines 369 398 +29
Branches 27 28 +1
==========================================
+ Hits 358 387 +29
Misses 11 11
Continue to review full report at Codecov.
|
jinwoo
approved these changes
Jun 8, 2018
test/test-lint.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| test.serial('lint should auto fix fixable errors unless dry-run', async t => { |
There was a problem hiding this comment.
The description sounds a little bit off from what is tested. Maybe 'lint should not auto fix on dry-run'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #118