test: resolve gtsRootDir in tests #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the tests are independent of where they are run from. Remove unnecessary lint test. Improve lint tests to avoid passing in lint config.
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 96.67% 96.62% -0.06%
==========================================
Files 10 10
Lines 331 326 -5
Branches 22 22
==========================================
- Hits 320 315 -5
Misses 11 11
Continue to review full report at Codecov.
|
This was referenced Jun 1, 2018
JustinBeckwith
approved these changes
Jun 1, 2018
jinwoo
approved these changes
Jun 1, 2018
| test.serial('createProgram should return an object', async t => { | ||
| await withFixtures({'tsconfig.json': '{}'}, async () => { | ||
| const program = lint.createProgram(OPTIONS); | ||
| t.truthy(program); | ||
| }); | ||
| }); | ||
|
|
||
| // TODO: make the error friendlier. This error implies that our module messed |
There was a problem hiding this comment.
The tests in this fine weren't fully thought through, and this one in particular wasn't needed. Instead of fixing the bug in lint.ts, the tests were always ensuring that there was a tslint.json in the specific test directory. This test was testing that the bug correctly existed 🤣.
There was a problem hiding this comment.
Sorry, this should had said.. fix the bug in the OPTIONS object construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the tests are independent of where they are run from.
Remove a test that was unnecessary.