Skip to content

Commit

Permalink
fix: disable esModuleInterop (#183)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: esModuleInterop causes synthetic imports to leak from
libraries to their users. Users must compile with allowSyntheticImports
as well if they use a library that uses this flag.

This has been causing a lot of churn in libraries that use gts.
  • Loading branch information
ofrobots committed Jul 3, 2018
1 parent b2b5bbd commit 94360af
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/cli.ts
Expand Up @@ -15,8 +15,8 @@
* limitations under the License.
*/
import * as path from 'path';
import meow from 'meow';
import updateNotifier from 'update-notifier';
import * as meow from 'meow';
import * as updateNotifier from 'update-notifier';
import {init} from './init';
import {clean} from './clean';

Expand Down
4 changes: 2 additions & 2 deletions src/util.ts
Expand Up @@ -16,8 +16,8 @@

import * as fs from 'fs';
import * as path from 'path';
import pify from 'pify';
import rimraf from 'rimraf';
import * as pify from 'pify';
import * as rimraf from 'rimraf';

export const readFilep = pify(fs.readFile);
export const rimrafp = pify(rimraf);
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures.ts
Expand Up @@ -16,9 +16,9 @@

import {test, Test} from 'ava';
import * as fs from 'fs';
import makeDir from 'make-dir';
import * as makeDir from 'make-dir';
import * as path from 'path';
import pify from 'pify';
import * as pify from 'pify';
import * as tmp from 'tmp';

const writeFilep = pify(fs.writeFile);
Expand Down
2 changes: 1 addition & 1 deletion test/test-format.ts
Expand Up @@ -15,7 +15,7 @@
*/

import test from 'ava';
import fs from 'fs';
import * as fs from 'fs';
import * as path from 'path';

import {Options} from '../src/cli';
Expand Down
2 changes: 1 addition & 1 deletion test/test-init.ts
Expand Up @@ -15,7 +15,7 @@
*/

import test from 'ava';
import path from 'path';
import * as path from 'path';

import {Options} from '../src/cli';
import * as init from '../src/init';
Expand Down
4 changes: 2 additions & 2 deletions test/test-kitchen.ts
Expand Up @@ -4,8 +4,8 @@ import * as cp from 'child_process';
import * as fs from 'fs';
import * as ncp from 'ncp';
import * as path from 'path';
import pify from 'pify';
import rimraf from 'rimraf';
import * as pify from 'pify';
import * as rimraf from 'rimraf';
import * as tmp from 'tmp';

interface ExecResult {
Expand Down
2 changes: 1 addition & 1 deletion test/test-lint.ts
Expand Up @@ -15,7 +15,7 @@
*/

import test from 'ava';
import fs from 'fs';
import * as fs from 'fs';
import * as path from 'path';

import {Options} from '../src/cli';
Expand Down
1 change: 0 additions & 1 deletion tsconfig-google.json
Expand Up @@ -4,7 +4,6 @@
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"declaration": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"lib": ["es2016"],
"module": "commonjs",
Expand Down

0 comments on commit 94360af

Please sign in to comment.