From 8cd74320f7f5063731e019cccd8822dc435a91fe Mon Sep 17 00:00:00 2001
From: Gerald Pape <ubergesundheit@users.noreply.github.com>
Date: Tue, 13 Nov 2018 13:18:37 +0100
Subject: [PATCH] fix(gatsby-plugin-offline): Sync docs with actual defaults
 being used (#9903)

I've noticed the Readme of gatsby-plugin-offline is out of sync with the actual defaults from its gatsby-node.js.

This commit fixes this by copying the options object from gatsby/packages/gatsby-plugin-offline/src/gatsby-node.js into this Readme.
---
 packages/gatsby-plugin-offline/README.md | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/packages/gatsby-plugin-offline/README.md b/packages/gatsby-plugin-offline/README.md
index 0ba71cf91163e..09493aff2882e 100644
--- a/packages/gatsby-plugin-offline/README.md
+++ b/packages/gatsby-plugin-offline/README.md
@@ -33,12 +33,11 @@ const options = {
   globDirectory: rootDir,
   globPatterns,
   modifyUrlPrefix: {
-    rootDir: ``,
     // If `pathPrefix` is configured by user, we should replace
     // the default prefix with `pathPrefix`.
-    "": args.pathPrefix || ``,
+    "/": `${pathPrefix}/`,
   },
-  navigateFallback: `/offline-plugin-app-shell-fallback/index.html`,
+  navigateFallback: `${pathPrefix}/offline-plugin-app-shell-fallback/index.html`,
   // Only match URLs without extensions or the query `no-cache=1`.
   // So example.com/about/ will pass but
   // example.com/about/?no-cache=1 and
@@ -47,17 +46,22 @@ const options = {
   // URLs and not any files hosted on the site.
   //
   // Regex based on http://stackoverflow.com/a/18017805
-  navigateFallbackWhitelist: [/^[^?]*([^.?]{5}|\.html)(\?.*)?$/],
+  navigateFallbackWhitelist: [/^([^.?]*|[^?]*\.([^.?]{5,}|html))(\?.*)?$/],
   navigateFallbackBlacklist: [/\?(.+&)?no-cache=1$/],
   cacheId: `gatsby-plugin-offline`,
-  // Don't cache-bust JS files and anything in the static directory
-  dontCacheBustUrlsMatching: /(.*js$|\/static\/)/,
+  // Don't cache-bust JS or CSS files, and anything in the static directory
+  dontCacheBustUrlsMatching: /(.*\.js$|.*\.css$|\/static\/)/,
   runtimeCaching: [
     {
       // Add runtime caching of various page resources.
       urlPattern: /\.(?:png|jpg|jpeg|webp|svg|gif|tiff|js|woff|woff2|json|css)$/,
       handler: `staleWhileRevalidate`,
     },
+    {
+      // Use the Network First handler for external resources
+      urlPattern: /^https?:/,
+      handler: `networkFirst`,
+    },
   ],
   skipWaiting: true,
   clientsClaim: true,