Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-returns-description requires description even when type is undefined #157

Closed
garyking opened this issue Feb 1, 2019 · 2 comments · Fixed by #167
Closed

require-returns-description requires description even when type is undefined #157

garyking opened this issue Feb 1, 2019 · 2 comments · Fixed by #167
Labels
enhancement released

Comments

@garyking
Copy link

garyking commented Feb 1, 2019

Unlike ESLint's built-in valid-jsdoc rule, require-returns-description requires a description even when the type is undefined.

Please allow for no description if return type is undefined. Otherwise, what are we supposed to put there?
@gajus
Copy link
Owner

gajus commented Feb 1, 2019

PR is welcome.

@golopot golopot mentioned this issue Mar 13, 2019
Merged
gajus added a commit that referenced this issue Mar 13, 2019
@gajus
feat: make require-returns-description accept void functions (fixes #157
39918c8 
)

feat: make require-returns-description accept void functions (fixes #157)
@gajus
Copy link
Owner

gajus commented Mar 13, 2019

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make require-returns-description accept void functions (fixes #157)
2 participants
@garyking @gajus