From dc2f86fe04cc9d4076aa4950bbaed8bf54f4761f Mon Sep 17 00:00:00 2001 From: Andrew Abramov Date: Tue, 23 Oct 2018 22:06:55 +0300 Subject: [PATCH] fix: support valid colon for require-description-complete-sentence rule (#98) --- src/rules/requireDescriptionCompleteSentence.js | 2 +- .../assertions/requireDescriptionCompleteSentence.js | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/rules/requireDescriptionCompleteSentence.js b/src/rules/requireDescriptionCompleteSentence.js index 3e7eaa8ec..6e36f63ec 100644 --- a/src/rules/requireDescriptionCompleteSentence.js +++ b/src/rules/requireDescriptionCompleteSentence.js @@ -10,7 +10,7 @@ const extractSentences = (text) => { // Remove all {} tags. .replace(/\{[\s\S]*?\}\s*/g, '') - .split(/[.?!:](?:\s+|$)/) + .split(/[.?!](?:\s+|$)/) // Ignore sentences with only whitespaces. .filter((sentence) => { diff --git a/test/rules/assertions/requireDescriptionCompleteSentence.js b/test/rules/assertions/requireDescriptionCompleteSentence.js index 0ade849e1..164839513 100644 --- a/test/rules/assertions/requireDescriptionCompleteSentence.js +++ b/test/rules/assertions/requireDescriptionCompleteSentence.js @@ -533,6 +533,16 @@ export default { */ function quux () { + } + ` + }, + { + code: ` + /** + * Hello: world. + */ + function quux () { + } ` }