Fix requireReadOnlyReactProps #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mrtnzlml
reviewed
May 23, 2019
| @@ -1,6 +1,7 @@ | |||
| const schema = []; | |||
|
|
|||
| const reComponentName = /^(Pure)?Component$/; | |||
| const reReadOnly = /^\$(ReadOnly|FlowFixMe)$/; | |||
There was a problem hiding this comment.
$FlowFixMe was just an example. It can be anything defined in suppress_type.
There was a problem hiding this comment.
how would we know what's defined there (from within a plugin rule)?
There was a problem hiding this comment.
You don't. This is why I was suggesting to not throw an error in cases where you don't know it's wrong for sure. :)
There was a problem hiding this comment.
Maybe allow to specify the suppress type name in an option of the rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$FlowFixMeis ignored{||}is considered to be read-only